Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for imkl (imkl.py) #3122

Merged
merged 1 commit into from
Feb 9, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for imkl (imkl.py) #3122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions easybuild/easyblocks/i/imkl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
from easybuild.tools.config import build_option
from easybuild.tools.filetools import apply_regex_substitutions, change_dir, mkdir, move_file, remove_dir, write_file
from easybuild.tools.modules import get_software_root
from easybuild.tools.run import run_cmd
from easybuild.tools.run import run_shell_cmd
from easybuild.tools.systemtools import get_shared_lib_ext


Expand Down Expand Up @@ -298,8 +298,8 @@ def build_mkl_fftw_interfaces(self, libdir):
self.log.info("Changed to interface %s directory %s", lib, intdir)

fullcmd = "%s %s" % (cmd, ' '.join(buildopts + extraopts))
res = run_cmd(fullcmd, log_all=True, simple=True)
if not res:
res = run_shell_cmd(fullcmd)
if res.exit_code:
raise EasyBuildError("Building %s (flags: %s, fullcmd: %s) failed", lib, flags, fullcmd)

for fn in os.listdir(tmpbuild):
Expand Down Expand Up @@ -344,8 +344,8 @@ def build_mkl_flexiblas(self, flexiblasdir):
'intel_thread parallel=intel SYSTEM_LIBS="-lm -ldl -L%s"' % compilerdir]]

for cmd in cmds:
res = run_cmd(cmd, log_all=True, simple=True)
if not res:
res = run_shell_cmd(cmd)
if res.exit_code:
raise EasyBuildError("Building FlexiBLAS-compatible library (cmd: %s) failed", cmd)

def post_install_step(self):
Expand All @@ -359,7 +359,7 @@ def post_install_step(self):
if os.path.exists(examples_subdir):
cwd = change_dir(examples_subdir)
for examples_tarball in glob.glob('examples_*.tgz'):
run_cmd("tar xvzf %s -C ." % examples_tarball)
run_shell_cmd("tar xvzf %s -C ." % examples_tarball)
change_dir(cwd)

# reload the dependencies
Expand Down
Loading