Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop testing easyconfig PRs with Travis, only use GitHub Actions from now on #11055

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 3, 2020

The tests in Travis CI have been a PITA recently: next to the frequent fluke failures (which were mitigated through my bot fairly efficiently), we've also been hitting timeouts where the test suite doesn't generate any output for too long, causing Travis to cancel the test job.

We tried using travis_wait (cfr. #11008) to make Travis be more patient, but that doesn't seem to be enough, see for example:

$ travis_wait python -O -m test.easyconfigs.suite

Still running (20 of 20): python -O -m test.easyconfigs.suite

Timeout (20 minutes) reached. Terminating "python -O -m test.easyconfigs.suite"

The command python -O -m test.easyconfigs.suite exited with 137.

(from https://travis-ci.org/github/easybuilders/easybuild-easyconfigs/jobs/714454534)

Since we're only testing with Python 2.7 and 3.6 in Travis, there's nothing we're testing in Travis that is not also being tested in GitHub Actions.

So, I'm calling it: no more testing with Travis for easyconfig PRs, only GitHub Actions from now on!

@boegel boegel added the change label Aug 3, 2020
@boegel boegel added this to the next release (4.2.3?) milestone Aug 3, 2020
@casparvl
Copy link
Contributor

casparvl commented Aug 3, 2020

Ok, I have to admit that I don't know exactly where the Travis integration links in, but I'm guessing on the easyconfigs side of things, it is limited to these two? Are there other places that need to be adapted together with this PR on the easybuild-framework side?

@boegel
Copy link
Member Author

boegel commented Aug 3, 2020

@casparvl The presence of the .travis.yml file determines whether Travis will test PRs (along with some configuration in Travis itself).

I'm only disabling Travis for the easyconfigs repository here. We can keep it for the other repos for now (and certainly for framework I'd like to for now, otherwise we won't be testing against Python 2.6 anymore).

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine by me.

Maybe the docs should be adjusted: they currently mention Travis (and only travis) https://easybuild.readthedocs.io/en/latest/Contributing.html#contributing-review-process-travis
but that's a detail.

@casparvl casparvl merged commit 50ccea0 into easybuilders:develop Aug 3, 2020
@casparvl
Copy link
Contributor

casparvl commented Aug 3, 2020

RIP Travis... Going in, thanks @boegel

@boegel
Copy link
Member Author

boegel commented Aug 4, 2020

@casparvl docs update in easybuilders/easybuild#641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants