-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--merge-pr refuses to merge easyconfig PRs because test suite is "pending" #3405
Comments
I've been in touch with GitHub Support over this... It turns out that the "commit status" (cfr. https://docs.github.com/en/rest/reference/repos#list-commit-statuses-for-a-reference and https://docs.github.com/en/rest/reference/repos#get-the-combined-status-for-a-specific-reference) only applies to the tests being by Travis CI, because GitHub Actions doesn't set the commit status but performs "check runs" (cfr. https://docs.github.com/en/rest/reference/checks#list-check-runs-for-a-git-reference and https://docs.github.com/en/rest/reference/checks#list-check-suites-for-a-git-reference). By no longer testing easyconfig PRs with Travis (see easybuilders/easybuild-easyconfigs#11055), we have nothing that is setting the commit status anymore, so it remains stuck in " To fix this, we have to update the logic used by |
Problem should be fixed with #3406... |
Example:
This is not correct, because the most recent commit in easybuilders/easybuild-easyconfigs#11090 got a green check mark (see easybuilders/easybuild-easyconfigs@0f37d99).
The text was updated successfully, but these errors were encountered: