Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--merge-pr refuses to merge easyconfig PRs because test suite is "pending" #3405

Closed
boegel opened this issue Aug 14, 2020 · 2 comments · Fixed by #3406
Closed

--merge-pr refuses to merge easyconfig PRs because test suite is "pending" #3405

boegel opened this issue Aug 14, 2020 · 2 comments · Fixed by #3406
Milestone

Comments

@boegel
Copy link
Member

boegel commented Aug 14, 2020

Example:

$ eb --merge-pr 11090
== temporary log file in case of crash /tmp/eb-2lDSgs/easybuild-DgLSzN.log

easybuilders/easybuild-easyconfigs PR #11090 was submitted by edmondac, you are using GitHub account 'boegel'

Checking eligibility of easybuilders/easybuild-easyconfigs PR #11090 for merging...
* targets develop branch: OK
* test suite passes: pending... => not eligible for merging!
...

This is not correct, because the most recent commit in easybuilders/easybuild-easyconfigs#11090 got a green check mark (see easybuilders/easybuild-easyconfigs@0f37d99).

@boegel boegel added this to the next release (4.2.3?) milestone Aug 14, 2020
@boegel
Copy link
Member Author

boegel commented Aug 14, 2020

I've been in touch with GitHub Support over this...

It turns out that the "commit status" (cfr. https://docs.github.com/en/rest/reference/repos#list-commit-statuses-for-a-reference and https://docs.github.com/en/rest/reference/repos#get-the-combined-status-for-a-specific-reference) only applies to the tests being by Travis CI, because GitHub Actions doesn't set the commit status but performs "check runs" (cfr. https://docs.github.com/en/rest/reference/checks#list-check-runs-for-a-git-reference and https://docs.github.com/en/rest/reference/checks#list-check-suites-for-a-git-reference).

By no longer testing easyconfig PRs with Travis (see easybuilders/easybuild-easyconfigs#11055), we have nothing that is setting the commit status anymore, so it remains stuck in "pending" forever.

To fix this, we have to update the logic used by --merge-pr to determine whether a PR has been given the green light to take into account both the "combined commit status" and the "check suites" results, and take into account that the "combined commit status" should be ignored if its "pending" and nothing is running to set the commit status (see for example https://api.github.com/repos/easybuilders/easybuild-easyconfigs/commits/06f73629a61d33485883ebb7079feed5f5d992aa/status, where state is pending and total_countis0`).

boegel added a commit to boegel/easybuild-framework that referenced this issue Aug 15, 2020
boegel added a commit to boegel/easybuild-framework that referenced this issue Aug 15, 2020
@boegel
Copy link
Member Author

boegel commented Aug 15, 2020

Problem should be fixed with #3406...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant