Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[GCC/10.3.0] FlexiBLAS v3.0.4 on top of OpenBLAS 0.3.15 #12476

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 25, 2021

@boegel boegel added the new label Mar 25, 2021
@boegel boegel added this to the next release (4.3.5?) milestone Apr 27, 2021
@boegel boegel changed the title {lib}[GCC/10.2.0] FlexiBLAS v3.0.4 on top of BLIS 0.8.0 + OpenBLAS 0.3.12 (WIP) {lib}[GCC/10.2.0] FlexiBLAS v3.0.4 on top of OpenBLAS 0.3.12 May 5, 2021
@boegel
Copy link
Member Author

boegel commented May 5, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8ed19790c180e0c69d9fc2bcc5f37f79 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot May 5, 2021
@boegel
Copy link
Member Author

boegel commented May 5, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/6615155d80d681997a09733318d8a859 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 10, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2369"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12476 EB_ARGS="--include-easyblocks-from-pr 2369" /apps/slurm/default/bin/sbatch --job-name test_PR_12476 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17071

Test results coming soon (I hope)...

- notification for comment with ID 836655549 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7f9661b74cef93b86f5861f0d3dfefc5 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 10, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0002 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/65c2967f127c296053a7dee30570d458 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 10, 2021

make test fails on POWER9, due to the tests not finding libflexiblas.so.3:

1/114 Testing: BLAS-xblat1s
1/114 Test: BLAS-xblat1s
Command: "/home/centos/EasyBuild/software/CMake/3.18.4-GCCcore-10.2.0/bin/cmake" "-DTEST=/tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/easybuild_obj/test/blas/xblat1s" "-DINTDIR=." "-P" "/tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/flexiblas-3.0.4/test/blas/runtest.cmake"
Directory: /tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/easybuild_obj/test/blas
"BLAS-xblat1s" start time: May 10 13:02 UTC
Output:
----------------------------------------------------------
-- "/tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/easybuild_obj/lib" -- PATH
Running: /tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/easybuild_obj/test/blas/xblat1s
ARGS=
/tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/easybuild_obj/test/blas/xblat1s: error while loading shared libraries: libflexiblas.so.3: cannot open shared object file: No such file or directory
CMake Error at /tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/flexiblas-3.0.4/test/blas/runtest.cmake:49 (message):
  Test /tmp/centos/FlexiBLAS/3.0.4/GCC-10.2.0/easybuild_obj/test/blas/xblat1s
  returned 127


<end of output>
Test time =   0.02 sec
----------------------------------------------------------
Test Failed.
"BLAS-xblat1s" end time: May 10 13:02 UTC
"BLAS-xblat1s" time elapsed: 00:00:00
----------------------------------------------------------

It's strange to me that this only happens on POWER9, not on x86_64 systems or on aarch64 (like Arm Graviton2)...

@branfosj @Flamefire Does this sort of problem happen to ring a bell for either of you?

@boegel
Copy link
Member Author

boegel commented May 10, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/ec83011bf5b5b158c74613c19f96901a for a full test report.

@boegel
Copy link
Member Author

boegel commented May 10, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3513.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/7a5fce2ac1a4317c455bf095cc8c9067 for a full test report.

@Flamefire
Copy link
Contributor

Does this sort of problem happen to ring a bell for either of you?

This is usually an LD_LIBRARY_PATH/rpath problem. Maybe your x86 nodes are picking something up from the system which you don't have on POWER? In any case can you check that manually an if that happens check ldd? Otherwise it is all just guessing.

@boegel
Copy link
Member Author

boegel commented May 11, 2021

Ah, right, I have RPATH linking enabled on that system (and not on the others), so the problem must indeed be RPATH related, thanks for the hint!

@ocaisa
Copy link
Member

ocaisa commented May 11, 2021

Test report by @ocaisa
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/b431b9eda9aeaef825352009bb8d04e0 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented May 11, 2021

Test report by @ocaisa
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/57090a74ba7802013b36421102a7fb20 for a full test report.

@boegel boegel force-pushed the 20210325170607_new_pr_FlexiBLAS304 branch from 2bfcf39 to c272e00 Compare May 11, 2021 16:52
@boegel
Copy link
Member Author

boegel commented May 11, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/34a0dfd886625a366de7e895ed789b92 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 11, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/f29839871937d263b70a8cc160a07dbd for a full test report.

@boegel
Copy link
Member Author

boegel commented May 11, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3503.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/117b6623148e5270445dd68b9711ec5b for a full test report.

@boegel
Copy link
Member Author

boegel commented May 11, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3503.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/eecf84417c8c56a451d2a7847dd8998c for a full test report.

@boegel
Copy link
Member Author

boegel commented May 11, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2369"

@easybuilders easybuilders deleted a comment from boegelbot May 11, 2021
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12476 EB_ARGS="--include-easyblocks-from-pr 2369" /apps/slurm/default/bin/sbatch --job-name test_PR_12476 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17077

Test results coming soon (I hope)...

- notification for comment with ID 838869930 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2369
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/76cf6237df3ff7bdb881bfb6b7129ce7 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 14, 2021

@grisuthedragon Only injecting those flags for the tests would require patching test/*/CMakeLists.txt, right?
Or is there another easy way to ensure those flags are only used when running make test?

Right now, I'm passing the flags via -DCMAKE_*_FLAGS when configuring the FlexiBLAS build with cmake, which is easy to do...

Since you'll start using those flags (only for the tests?) in future FlexiBLAS versions, a patch for test/*/CMakeLlists.txt is perhaps better, just to avoid duplicating those flags for future FlexiBLAS versions (which shouldn't break anything, but it's not clean :) ).

@boegel
Copy link
Member Author

boegel commented May 14, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2426
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2669.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/08d2fec2fa07cf19ded5b01600299db9 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 14, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2426
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/d5547cd2fe55241abf1c3d7e19487feb for a full test report.

@boegel
Copy link
Member Author

boegel commented May 14, 2021

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2426
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/65278f7a4e1e00fa605fb6d69588bf53 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 14, 2021

Note: this should not be merged until #12755 is merged, since Python is a build dependency for FlexiBLAS (required for running the tests).

@boegel
Copy link
Member Author

boegel commented May 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/5acb176e7706070c7747ad4c0a1a2fa9 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/6dd340f88073c3f2fd52726a70c7e717 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3129.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/d165ab62a15e783f792e78e6c2f2b7ba for a full test report.

@boegel
Copy link
Member Author

boegel commented May 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3515.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/e5f8ba8387b0f21b065957c5c4ee3d91 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 22, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/a35adac92e0a3091004cb9d55afbb74e for a full test report.

@boegel boegel marked this pull request as ready for review May 22, 2021 18:03
@branfosj branfosj dismissed smoors’s stale review May 23, 2021 10:31

requested changes dealt with

branfosj
branfosj previously approved these changes May 23, 2021
Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/e494ba6bb1197aae20ef897872087dd4 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/2a056431291d87f3da32aff36bf318d2 for a full test report.

]

# note: first listed library will be used as default by FlexiBLAS,
# unless otherwise specified via -DFLEXIBLAS_DEFAULT in configopts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# unless otherwise specified via -DFLEXIBLAS_DEFAULT in configopts
# unless otherwise specified via easyconfig parameter flexiblas_default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 5daaacb

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented May 23, 2021

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=12476 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12476 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17286

Test results coming soon (I hope)...

- notification for comment with ID 846546674 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3304cdd1a74830efee3ea2f700eff49c for a full test report.

@smoors
Copy link
Contributor

smoors commented May 23, 2021

Going in, thanks @boegel!

@smoors smoors merged commit a27285d into easybuilders:develop May 23, 2021
@boegel boegel deleted the 20210325170607_new_pr_FlexiBLAS304 branch May 23, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants