-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2020b] PPanGGOLiN v1.1.136 + dependencies #14399
{bio}[foss/2020b] PPanGGOLiN v1.1.136 + dependencies #14399
Conversation
…foss-2020b.eb, Infernal-1.1.4-foss-2020b.eb, genoPlotR-0.8.11-foss-2020b.eb, rpy2-3.4.5-foss-2020b.eb and patches: PPanGGOLiN-1.1.136_new_compiler_compatibility.patch
@boegel please take a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deniskristak Can you take a look at how painful it would to move this to the foss/2021b
toolchain, so we can just add genoPlotR
as an extension to R
4.1.2?
I need to add a couple of other extensions to R anyway, I'll include genoPlotR
straight away as well...
checksums = ['f127f7fe8b19c899ecfdf98bf69d2e18926afb593a72fc40097acca66d401607'] | ||
|
||
dependencies = [ | ||
('R', '4.0.3'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this only depends on R
, we should probably just add this as an extension to R
itself?
I would prefer doing that only for the latest R
version we have though (4.1.2 with foss/2021b
)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deniskristak I've added genoPlotR
to R
4.1.2 in #14433
checksums = ['f9493c7dee9fbf25f6405706818883d24b9f5e455121a0662c96c8f0307f95fc'] | ||
|
||
sanity_check_paths = { | ||
'files': ['bin/cm%s' % x for x in ['align', 'build', 'calibrate', 'convert', 'emit', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do any of these support --help
or --version
, or similar?
If so, please add a sanity check command for some (or all) of them.
If you do all, introduce a local variable local_bins = ['bin/cm%s' % x for x in ['align', ...]]
easybuild/easyconfigs/p/PPanGGOLiN/PPanGGOLiN-1.1.136-foss-2020b.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/p/PPanGGOLiN/PPanGGOLiN-1.1.136-foss-2020b.eb
Outdated
Show resolved
Hide resolved
] | ||
|
||
# sanity_check_commands = [ | ||
# "pytest --pyargs rpy2 " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had to figure out how to do this properly, because the above didnt prevent tests from running (and failing)...its updated now
@deniskristak Trivial code style issue to fix:
|
@deniskristak: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1508484726
bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
@deniskristak I think this can be closed, superseded by #14449? |
adding easyconfigs: PPanGGOLiN-1.1.136-foss-2020b.eb, ARAGORN-1.2.41-foss-2020b.eb, Infernal-1.1.4-foss-2020b.eb, genoPlotR-0.8.11-foss-2020b.eb, rpy2-3.4.5-foss-2020b.eb and patches: PPanGGOLiN-1.1.136_new_compiler_compatibility.patch