Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2020b] PPanGGOLiN v1.1.136 + dependencies #14399

Conversation

deniskristak
Copy link
Contributor

adding easyconfigs: PPanGGOLiN-1.1.136-foss-2020b.eb, ARAGORN-1.2.41-foss-2020b.eb, Infernal-1.1.4-foss-2020b.eb, genoPlotR-0.8.11-foss-2020b.eb, rpy2-3.4.5-foss-2020b.eb and patches: PPanGGOLiN-1.1.136_new_compiler_compatibility.patch

deniskristak added 2 commits November 23, 2021 12:12
…foss-2020b.eb, Infernal-1.1.4-foss-2020b.eb, genoPlotR-0.8.11-foss-2020b.eb, rpy2-3.4.5-foss-2020b.eb and patches: PPanGGOLiN-1.1.136_new_compiler_compatibility.patch
@deniskristak
Copy link
Contributor Author

@boegel please take a look at aragorn easyconfig line 28 if we can do anything about that

@easybuilders easybuilders deleted a comment from boegelbot Nov 24, 2021
@boegel boegel changed the title PPanGGOLiN and deps {bio}[foss/2020b] PPanGGOLiN v1.1.136 + dependencies Nov 25, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deniskristak Can you take a look at how painful it would to move this to the foss/2021b toolchain, so we can just add genoPlotR as an extension to R 4.1.2?

I need to add a couple of other extensions to R anyway, I'll include genoPlotR straight away as well...

checksums = ['f127f7fe8b19c899ecfdf98bf69d2e18926afb593a72fc40097acca66d401607']

dependencies = [
('R', '4.0.3'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only depends on R, we should probably just add this as an extension to R itself?

I would prefer doing that only for the latest R version we have though (4.1.2 with foss/2021b)...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deniskristak I've added genoPlotR to R 4.1.2 in #14433

checksums = ['f9493c7dee9fbf25f6405706818883d24b9f5e455121a0662c96c8f0307f95fc']

sanity_check_paths = {
'files': ['bin/cm%s' % x for x in ['align', 'build', 'calibrate', 'convert', 'emit',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of these support --help or --version, or similar?
If so, please add a sanity check command for some (or all) of them.

If you do all, introduce a local variable local_bins = ['bin/cm%s' % x for x in ['align', ...]]

]

# sanity_check_commands = [
# "pytest --pyargs rpy2 "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to figure out how to do this properly, because the above didnt prevent tests from running (and failing)...its updated now

@boegel boegel added the update label Nov 25, 2021
@boegel boegel added this to the 4.x milestone Nov 25, 2021
@boegel
Copy link
Member

boegel commented Nov 25, 2021

@deniskristak Trivial code style issue to fix:

$ eb --from-pr 14399 --check-style
== Temporary log file in case of crash /tmp/eb-1lh0xz7p/easybuild-r4cb77p0.log

Running style check on 5 easyconfig(s)...

[PASS] /tmp/eb-1lh0xz7p/files_pr14399/a/ARAGORN/ARAGORN-1.2.41-foss-2020b.eb
[PASS] /tmp/eb-1lh0xz7p/files_pr14399/g/genoPlotR/genoPlotR-0.8.11-foss-2020b.eb
[PASS] /tmp/eb-1lh0xz7p/files_pr14399/i/Infernal/Infernal-1.1.4-foss-2020b.eb
/tmp/eb-1lh0xz7p/files_pr14399/p/PPanGGOLiN/PPanGGOLiN-1.1.136-foss-2020b.eb:49:121: E501 line too long (131 > 120 characters)
[FAIL] /tmp/eb-1lh0xz7p/files_pr14399/p/PPanGGOLiN/PPanGGOLiN-1.1.136-foss-2020b.eb
[PASS] /tmp/eb-1lh0xz7p/files_pr14399/r/rpy2/rpy2-3.4.5-foss-2020b.eb

@boegelbot
Copy link
Collaborator

@deniskristak: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1508484726
Output from first failing test suite run:

Merge base for develop and HEAD: 770a7b8a9c620bc6afbfffad28d6c9e969b1ccb3
======================================================================
Merge base for develop and HEAD: 770a7b8a9c620bc6afbfffad28d6c9e969b1ccb3
FAIL: test_pr_python_packages (test.easyconfigs.easyconfigs.EasyConfigTest)

Several checks for easyconfigs that install (bundles of) Python packages.
List of added easyconfig files in this PR:
----------------------------------------------------------------------
	ARAGORN-1.2.41-foss-2020b.eb
Traceback (most recent call last):
	genoPlotR-0.8.11-foss-2020b.eb
  File "test/easyconfigs/easyconfigs.py", line 981, in test_pr_python_packages
	Infernal-1.1.4-foss-2020b.eb
    self.fail('\n'.join(failing_checks))
	PPanGGOLiN-1.1.136-foss-2020b.eb
AssertionError: '*download_dep_fail' should not be set in PPanGGOLiN-1.1.136-foss-2020b.eb since PythonBundle easyblock is used
	rpy2-3.4.5-foss-2020b.eb

----------------------------------------------------------------------
Ran 13712 tests in 517.245s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@easybuilders easybuilders deleted a comment from boegelbot Nov 27, 2021
@boegel
Copy link
Member

boegel commented Nov 28, 2021

@deniskristak I think this can be closed, superseded by #14449?

@boegel boegel closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants