Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up OpenMPI 4.1.4 configure by not running "autogen.pl --force", but only running required Autotools commands #15957

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Aug 2, 2022

(created using eb --new-pr)

This runs only a (relevant) subset of the autogen.pl script as suggested by @Micket on Slack which seemingly speeds up the configure enough to make it not timeout on some machines (e.g. our PPC cluster)

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusml4 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), 6 x NVIDIA Tesla V100-SXM2-32GB, 440.64.00, Python 2.7.5
See https://gist.github.com/6168d2c33caf1fd06c7de3f2474bceda for a full test report.

Add `cd ..` as its own command like the others
@boegel
Copy link
Member

boegel commented Aug 3, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15957 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15957 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8939

Test results coming soon (I hope)...

- notification for comment with ID 1204033126 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8d23586d38a0dd758c68241792635b56 for a full test report.

boegel
boegel previously requested changes Aug 4, 2022
@@ -36,7 +36,16 @@ dependencies = [
('UCC', '1.0.0'),
]

preconfigopts = './autogen.pl --force && '
preconfigopts = ' && '.join([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flamefire @bartoldeman I think it makes sense to add a comment block above this line to explain i) why this is needed, ii) why we're not using autogen.pl, iii) why the commands we are using are sufficient.

Without that, people are bound to start wondering in the future why we're doing it like this rather than just running autogen.pl...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI I did a diff between the result for both methods and the only differences are updates to various autoconf-supplied files which are irrelevant to the changes in the patches. So it's safe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

@boegel boegel changed the title Speed up OpenMPI 4.1.4 configure speed up OpenMPI 4.1.4 configure by not running "autogen.pl --force", but only running required Autotools commands Aug 4, 2022
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

@boegelbot Please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@akesandgren: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=15957 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15957 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1600

Test results coming soon (I hope)...

- notification for comment with ID 1230357738 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@akesandgren akesandgren dismissed stale reviews from boegel and bartoldeman August 29, 2022 14:09

Requested change implemented

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/7bacedb74c6ddf75ba19ba900e924719 for a full test report.

@akesandgren
Copy link
Contributor

Going in, thanks @Flamefire!

@akesandgren akesandgren merged commit 1d3c794 into easybuilders:develop Aug 29, 2022
@Flamefire Flamefire deleted the 20220802161756_new_pr_OpenMPI414 branch September 5, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants