Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up OpenMPI 4.1.4 configure by not running "autogen.pl --force", but only running required Autotools commands #15957

Merged
merged 3 commits into from
Aug 29, 2022
Merged

speed up OpenMPI 4.1.4 configure by not running "autogen.pl --force", but only running required Autotools commands #15957

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9ee2e8
Speed up OpenMPI 4.1.4 configure
Flamefire Aug 2, 2022
39530f8
Fix style issue in preconfigopts
Flamefire Aug 3, 2022
ffd384d
Add comment to descript purpose of preconfigopts
Flamefire Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion easybuild/easyconfigs/o/OpenMPI/OpenMPI-4.1.4-GCC-11.3.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,19 @@ dependencies = [
('UCC', '1.0.0'),
]

preconfigopts = './autogen.pl --force && '
# Update configure to include changes from the "internal-cuda" patch
# by running a subset of autogen.pl sufficient to achieve this
# without doing the full, long-running regeneration.
preconfigopts = ' && '.join([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flamefire @bartoldeman I think it makes sense to add a comment block above this line to explain i) why this is needed, ii) why we're not using autogen.pl, iii) why the commands we are using are sufficient.

Without that, people are bound to start wondering in the future why we're doing it like this rather than just running autogen.pl...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI I did a diff between the result for both methods and the only differences are updates to various autoconf-supplied files which are irrelevant to the changes in the patches. So it's safe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

'cd config',
'autom4te --language=m4sh opal_get_version.m4sh -o opal_get_version.sh',
'cd ..',
'autoconf',
'autoheader',
'aclocal',
'automake',
''
])

# CUDA related patches and custom configure option can be removed if CUDA support isn't wanted.
configopts = '--with-cuda=internal '
Expand Down