Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bzip2 and libxml2 as dependencies for netCDF 4.9.0 #16450

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Oct 20, 2022

(created using eb --new-pr)

Add sanity check commands in easybuilders/easybuild-easyblocks#2811

fix #16446

  • bzip2 is a dep of CMake, which is used as a builddep. So bzip2 is detected and compiled against, but then not available at runtime.
  • libxml2 is also compiled against, so make it an explicit dependency.

@boegel boegel added the bug fix label Oct 20, 2022
@boegel boegel added this to the next release (4.6.2?) milestone Oct 20, 2022
@boegel
Copy link
Member

boegel commented Oct 20, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16450 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16450 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9324

Test results coming soon (I hope)...

- notification for comment with ID 1285222680 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Oct 20, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3104.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/7246b502fb18da9ac22bfd5f28dfa542 for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2811
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/05cd7635757c403f298005e82413e154 for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Oct 20, 2022

Test report by @jfgrimm
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2811
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node151.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/42d92c1f2e60eefb4eb8a733e021b8cf for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns8 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a1e98ef2d106a9d2e52e17ca9fd4ccbd for a full test report.

@boegel
Copy link
Member

boegel commented Oct 20, 2022

@boegelbot please test @ jsc-zen2
EB_ARGS="--include-easyblocks-from-pr 2811"

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16450 EB_ARGS="--include-easyblocks-from-pr 2811" /opt/software/slurm/bin/sbatch --job-name test_PR_16450 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1713

Test results coming soon (I hope)...

- notification for comment with ID 1285260362 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title add bzip2 and libxml2 as deps to netCDF 4.9.0 add bzip2 and libxml2 as dependencies for netCDF 4.9.0 Oct 20, 2022
@boegel
Copy link
Member

boegel commented Oct 20, 2022

Going in, thanks @branfosj!

@boegel boegel merged commit 0694ae6 into easybuilders:develop Oct 20, 2022
@branfosj branfosj deleted the 20221020101735_new_pr_netCDF490 branch October 20, 2022 10:05
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2811
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/e5312123f184a65001e4b54040f37866 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netCDF/4.9.0-gompi-2022a is missing a dependency
4 participants