add support for --install-github-token and --check-github (REVIEW) #1616

boegel · 2016-02-17T07:58:42Z

Example output:

$ eb --check-github
== temporary log file in case of crash /var/folders/8s/_frgh9sj6m744mxt5w5lyztr0000gn/T/eb-UwwYW2/easybuild-Y_GLrS.log

Checking status of GitHub integration...

* GitHub user... boegel => OK
* GitHub token... a3e..9fc (len: 40) => OK (validated)
* git command... OK ("git version 2.5.4 (Apple Git-61); ")
* GitPython module... OK
* push access to boegel/easybuild-easyconfigs repo @ GitHub... OK
* creating gists... OK
* location to Git working dirs... OK (/Users/kehoste/work)

All checks PASSed!

Status of GitHub integration:
* --from-pr: OK
* --new-pr: OK
* --review-pr: OK
* --update-pr: OK
* --upload-test-report: OK

hpcugentbot · 2016-02-17T08:15:53Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2704/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2016-02-17T13:50:20Z

Jenkins: test this please

hpcugentbot · 2016-02-17T14:01:35Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2707/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-17T17:10:16Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2709/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-19T18:32:52Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2739/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-19T20:02:25Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2741/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-02-19T22:08:20Z

I'm happy with this now...

@wpoely86: please review?

hpcugentbot · 2016-02-19T22:10:04Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2742/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-19T22:51:06Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2743/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

wpoely86 · 2016-02-20T13:30:56Z

easybuild/main.py

@@ -152,6 +152,31 @@ def build_and_install_software(ecs, init_session_state, exit_on_failure=True):
    return res


+def handle_github_options(options, orig_paths):
+    """Handle options related to GitHub integration, if any are set."""


wpoely86 · 2016-02-20T13:49:02Z

easybuild/tools/github.py

+    if all(status.values()):
+        print "\nAll checks PASSed!\n"
+    else:
+        print '\n'.join([


why not just do a multi line string?

ugly because of indenting...

hpcugentbot · 2016-02-22T19:02:57Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2753/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

hpcugentbot · 2016-02-23T12:48:23Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2755/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

wpoely86 · 2016-02-23T16:47:03Z

easybuild/tools/github.py

+                                 current_token, github_user)
+
+    # get token to install
+    token = getpass.getpass(prompt="Token: ")


you this be wrapped in a try? What if the user simple presses enter?

then they'll try to install an invalid token, and the sanity check on it will fail

hpcugentbot · 2016-02-23T16:58:05Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2760/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

…ct remote

boegel · 2016-03-04T08:18:42Z

Jenkins: test this please

boegel · 2016-03-04T08:38:23Z

Jenkins PR builder plugin was updated...

Jenkins: test this please

hpcugentbot · 2016-03-04T10:13:23Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2830/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-03-15T08:30:58Z

Jenkins: test this please

hpcugentbot · 2016-03-15T10:58:07Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2871/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2016-03-15T11:27:19Z

Not holding this back any longer, it's time this goes in so it can be included in EasyBuild v2.7.0.

The documentation update at easybuilders/easybuild#199 is still in the works, I'll try and get that done ASAP.

add support for --install-github-token and --check-github (REVIEW)

boegel added 8 commits February 15, 2016 16:36

add support for --check-github-config (WIP)

639c077

further flesh out --check-github implementaton (still WIP)

b0db2a9

add support for --install-github-token

d3401e4

add tests for validate_github_token and install_github_token functions

eaea5d6

check whether we're online first, befor checking GitHub access

d6aa695

cleanup/refactor

1dcfae3

include status overview of GitHub integration

fac1e80

add check for --git-working-dirs-path

6c95190

boegel added this to the v2.7.0 milestone Feb 17, 2016

boegel mentioned this pull request Feb 17, 2016

EasyBuild 2.7.0 (roadmap) easybuilders/easybuild#192

Closed

17 tasks

boegel changed the title ~~add support for --install-github-token and --check-github~~ add support for --install-github-token and --check-github (WIP) Feb 17, 2016

Merge branch 'develop' into check_github

1be4d62

Merge branch 'develop' into check_github

284f6f3

boegel added 2 commits February 19, 2016 20:23

fix if check for GitHub integration options (argh!)

2b1f2b8

flesh out handling of GitHub integration options

080e64f

refactor, fix FIXMEs, drop clone_rep

cbaab17

boegel changed the title ~~add support for --install-github-token and --check-github (WIP)~~ add support for --install-github-token and --check-github (REVIEW) Feb 19, 2016

pass down orig_paths

c162444

wpoely86 reviewed Feb 20, 2016
View reviewed changes

boegel added 4 commits February 21, 2016 14:05

fix error msg

b63c9c6

first round of fixing remarks

ad9ac07

fix moar remarks

914e4c8

fix even moarrrrr remarks

e5d9c5c

rewrite --install-github-token with getpass

273cb85

fix test for install_github_token

27d94d5

wpoely86 reviewed Feb 23, 2016
View reviewed changes

boegel added 3 commits March 1, 2016 12:03

Merge branch 'develop' into check_github

8258fa9

Merge branch 'develop' into check_github

094aa95

always set up repo with git@github.com to test push access, use corre…

f684860

…ct remote

boegel added a commit that referenced this pull request Mar 15, 2016

Merge pull request #1616 from boegel/check_github

0479d88

add support for --install-github-token and --check-github (REVIEW)

boegel merged commit 0479d88 into easybuilders:develop Mar 15, 2016

boegel deleted the check_github branch March 15, 2016 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for --install-github-token and --check-github (REVIEW) #1616

add support for --install-github-token and --check-github (REVIEW) #1616

boegel commented Feb 17, 2016

hpcugentbot commented Feb 17, 2016

boegel commented Feb 17, 2016

hpcugentbot commented Feb 17, 2016

hpcugentbot commented Feb 17, 2016

hpcugentbot commented Feb 19, 2016

hpcugentbot commented Feb 19, 2016

boegel commented Feb 19, 2016

hpcugentbot commented Feb 19, 2016

hpcugentbot commented Feb 19, 2016

wpoely86 Feb 20, 2016

wpoely86 Feb 20, 2016

boegel Feb 22, 2016

hpcugentbot commented Feb 22, 2016

hpcugentbot commented Feb 23, 2016

wpoely86 Feb 23, 2016

boegel Feb 26, 2016

hpcugentbot commented Feb 23, 2016

boegel commented Mar 4, 2016

boegel commented Mar 4, 2016

hpcugentbot commented Mar 4, 2016

boegel commented Mar 15, 2016

hpcugentbot commented Mar 15, 2016

boegel commented Mar 15, 2016

add support for --install-github-token and --check-github (REVIEW) #1616

add support for --install-github-token and --check-github (REVIEW) #1616

Conversation

boegel commented Feb 17, 2016

hpcugentbot commented Feb 17, 2016

boegel commented Feb 17, 2016

hpcugentbot commented Feb 17, 2016

hpcugentbot commented Feb 17, 2016

hpcugentbot commented Feb 19, 2016

hpcugentbot commented Feb 19, 2016

boegel commented Feb 19, 2016

hpcugentbot commented Feb 19, 2016

hpcugentbot commented Feb 19, 2016

wpoely86 Feb 20, 2016

Choose a reason for hiding this comment

wpoely86 Feb 20, 2016

Choose a reason for hiding this comment

boegel Feb 22, 2016

Choose a reason for hiding this comment

hpcugentbot commented Feb 22, 2016

hpcugentbot commented Feb 23, 2016

wpoely86 Feb 23, 2016

Choose a reason for hiding this comment

boegel Feb 26, 2016

Choose a reason for hiding this comment

hpcugentbot commented Feb 23, 2016

boegel commented Mar 4, 2016

boegel commented Mar 4, 2016

hpcugentbot commented Mar 4, 2016

boegel commented Mar 15, 2016

hpcugentbot commented Mar 15, 2016

boegel commented Mar 15, 2016