-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs on GitHub integration, mention --new-pr/--update-pr #199
Conversation
…--check-github and --upload-test-report output
@wpoely86, @pescobar, @fgeorgatos, @rjeschmi I finally got around to completing this... Please review? |
why not enable maybe it's worth mentioning that a recent python-keyring version is needed? I remember I had issues with this but I don't rember the specific version I had to use... otherwise, lgtm |
@boegel Quick feedback about the It says location of your Git working directories, which one? easyconfig, easyblock, ... ? only one? multiples? all of them? I think this could be clarified. |
|
||
This takes care of all the steps required to make a contribution, i.e.: | ||
|
||
* set up a working copy of the relevant EasyBuild repository (e.g., ``easybuild-easyconfigs``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit unclear to me. From the example, it seems that only easyconfigs can be handles by this option. But with the information about --pr-target-repo
below, I get the impression that also framework/easyblock PRs can be handled. However, in this case, the question is how the automatic renaming/moving works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geimer For now, in the experimental stage, --new-pr
and --update-pr
only support easyconfigs, but the intention is to extend this to easyblocks and framework too.
For easyblocks, we can derive the correct name & location as well. For framework, we will only be able to support patching of existing modules, but that should cover 95% of all uses.
The documentation is written with that in mind, and so is the --pr-target-repo
configure option.
@boegel: I don't think I was involved in this stuff... But anyway, I did a quick review and in general it looks reasonable to me. |
@boegel: I don't think so. A |
@geimer hmm, ok, sorry for the noise then, I must be misremembering... |
going in, thanks for the feedback everyone! |
preview at http://boegel-eb.readthedocs.org/en/new_update_pr/Integration_with_GitHub.html