Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure type module is run during a dry run #4721

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Dec 11, 2024

closes #4713

https://github.com/branfosj/easybuild-framework/actions/runs/12279931868/job/34265127454 shows that adding "eb -x bzip2-1.0.8.eb" to the end-to-end test fails before the changes in this PR.

@branfosj branfosj added this to the 5.0 milestone Dec 11, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title make sure type module in run during a dry run make sure type module is run during a dry run Dec 11, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel enabled auto-merge December 11, 2024 15:55
@boegel boegel merged commit 1de2441 into easybuilders:5.0.x Dec 11, 2024
39 checks passed
@branfosj branfosj deleted the extended_dry_run branch December 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants