Skip to content

Commit

Permalink
ICU-22220 Automate BRS tasks
Browse files Browse the repository at this point in the history
  • Loading branch information
echeran committed Feb 15, 2023
1 parent 288c4c7 commit 5e06b0b
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 1 deletion.
62 changes: 61 additions & 1 deletion .github/workflows/icu_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -573,4 +573,64 @@ jobs:
# To run all tests serially
echo "Run all samples"
pwd
PATH=$PATH:/tmp/icu_samples/bin LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/tmp/icu_samples/lib make check-samples-recursive
PATH=$PATH:/tmp/icu_samples/bin LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/tmp/icu_samples/lib make check-samples-recursive
# https://unicode-org.github.io/icu/processes/release/tasks/integration.html#verify-that-icu4c-tests-pass-without-collation-rule-strings
icu4c-without-collation-rule-strings:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install hjson dependency
run: |
sudo apt-get install python3-pip
pip3 install hjson
- name: Create data filter file to remove collation rule strings
run: |
cat > icu4c/coll-norules.hjson <<EOL
{
resourceFilters: [
{
categories: [
coll_tree
]
rules: [
-/UCARules
-/collations/*/Sequence
]
}
]
}
EOL
- name: Configure ICU4C with the data filter file
env:
ICU_DATA_FILTER_FILE: ../coll-norules.hjson
run: |
cd icu4c/source
./runConfigureICU Linux
- name: Run tests with data-errors-as-warnings
env:
INTLTEST_OPTS: -w
CINTLTST_OPTS: -w
run: |
cd icu4c/source
make -j2 check
# https://unicode-org.github.io/icu/processes/release/tasks/healthy-code.html#test-uconfig_no_conversion
icu4c-uconfig-no-version:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set UCONFIG_NO_CONVERSION and configure ICU4C
env:
UCONFIG_NO_CONVERSION: 1
run: |
cd icu4c/source
./runConfigureICU Linux
- name: Run make for stubdata, common, i18n
run: |
cd icu4c/source
pushd stubdata && make -j 2 && popd
# Ensure lib directory for output object file exists
mkdir -p lib
pushd common && make -j 2 && popd
pushd i18n && make -j 2 && popd
3 changes: 3 additions & 0 deletions docs/processes/release/tasks/healthy-code.md
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,9 @@ The automated build system should have a machine that sets both
## Test UCONFIG_NO_CONVERSION
Note: Since ICU 73, this test has been included in the Github Actions Continuous Integration jobs.
These instructions explain how to run the test manually.
Make sure that the ICU4C common and i18n libraries build with
UCONFIG_NO_CONVERSION set to 1. We cannot do this as part of "Test uconfig.h
variations" because the test suites cannot be built like this, but the library
Expand Down
3 changes: 3 additions & 0 deletions docs/processes/release/tasks/integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ now, this task is not required for ICU4J.

## Verify that ICU4C tests pass without collation rule strings

Note: Since ICU 73, this test has been included in the Github Actions Continuous Integration jobs.
These instructions explain how to run the test manually.

***ICU4C 53 and later***

Background: [ICU-10636](https://unicode-org.atlassian.net/browse/ICU-10636)
Expand Down

0 comments on commit 5e06b0b

Please sign in to comment.