Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration file with the default values #147

Closed
mwperina opened this issue Feb 14, 2023 · 0 comments · Fixed by #177
Closed

Add configuration file with the default values #147

mwperina opened this issue Feb 14, 2023 · 0 comments · Fixed by #177
Assignees
@ArtiomDivak
Labels
jira Issues that are synced to Jira

Comments

@mwperina
Copy link
Member

mwperina commented Feb 14, 2023 •
edited
Loading

We need to provide 2 different level of configuration files for hirte and hirte-agent:

  • The configuration file providing the options' default values, which should not be editable by users and which should be overwritten on each package installation
  • The configuration file provider the custom values, which is editable by users and which should be preserved during package installation

Here is suggested solution for hirte manager:

  • /usr/share/hirte/config/hirte-default.conf
    • This file should enlist all existing configuration options along with descriptions and allowed values
    • It should provide default values for all options, where it makes sense and it should also mention options, which don't have a default value (for example ManagerHost)
    • This file should not be modified by users
    • This file will be overwritten on each package installation
  • /etc/hirte/hirte.conf
    • This file should by default contain only options, which don't have default value and which should be modified by users
    • Users could add there any options from /usr/share/hirte/config/hirte-default.conf to modify their value
    • Users' customization of this file should be preserved during package installation

Solution for hirte-agent is very similar, just configuration file paths are different:

  • /usr/share/hirte-agent/config/hirte-default.conf
    • The configuration file for the default values
  • /etc/hirte/agent.conf
    • The configuration file to custom values modified by users

Using above configuration files should also change the order of loading configurations files during hirte/hirte-agent startup:

  1. Load the default configuration values from /usr/share and store them to the configuration hash map
  2. Load user customizations from /etc and overwrite updated values in the configuration hash map
  3. Check if all required options have a valid value
@mwperina mwperina added the jira Issues that are synced to Jira label Feb 14, 2023
@mwperina mwperina mentioned this issue Feb 14, 2023
Closed
@mwperina mwperina added jira Issues that are synced to Jira and removed jira Issues that are synced to Jira labels Mar 1, 2023
@mwperina mwperina mentioned this issue Mar 1, 2023
Closed
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 6, 2023
@ArtiomDivak
Issues 147
7c970b8 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Signed-off-by: ArtiomDivak <adivak@redhat.com>
@ArtiomDivak ArtiomDivak mentioned this issue Mar 6, 2023
Merged
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 6, 2023
@ArtiomDivak
Issues 147
343169d 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 7, 2023
@ArtiomDivak
Issues 147
812dbf8 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 7, 2023
@ArtiomDivak
Add support for conf.d configuration files
450a2c1 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: ArtiomDivak adivak@redhat.com
@ArtiomDivak ArtiomDivak mentioned this issue Mar 7, 2023
Merged
@mwperina mwperina mentioned this issue Mar 7, 2023
Closed
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 7, 2023
@ArtiomDivak
Load initial config file with the default values
ecb63c4 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 8, 2023
@ArtiomDivak
Load initial config file with the default values
45139e5 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina pushed a commit to ArtiomDivak/BlueChi that referenced this issue Mar 10, 2023
@ArtiomDivak @mwperina
Load initial config file with the default values
2fe5166 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina pushed a commit to ArtiomDivak/BlueChi that referenced this issue Mar 10, 2023
@ArtiomDivak @mwperina
Load initial config file with the default values
47127df 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina pushed a commit to ArtiomDivak/BlueChi that referenced this issue Mar 10, 2023
@ArtiomDivak @mwperina
Load initial config file with the default values
1442f28 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
@engelmi engelmi added the v0.1 label Mar 10, 2023
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
a925762 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
3bfa979 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
cebbc68 
For a full description please read here
#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: #147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
77fe0a7 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
984b287 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
0e0dc1e 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
f322ae5 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
4450697 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
7ed40ee 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 13, 2023
@ArtiomDivak
Load initial config file with the default values
d3b644b 
For a full description please read here
eclipse-bluechi#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed

Fixes: eclipse-bluechi#147
Signed-off-by: Artiom Divak <adivak@redhat.com>
@ArtiomDivak ArtiomDivak mentioned this issue Mar 13, 2023
Closed
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 20, 2023
@ArtiomDivak
Add support for conf.d configuration files
d4c5a78 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 20, 2023
@ArtiomDivak
Add support for conf.d configuration files
fb5ef2a 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
f6d2da4 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
f1f8909 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
57985b3 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
8f4bce0 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
c6cc60a 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
db46ce3 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
91f3952 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
ed7f467 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
5c33b41 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
d81699b 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
41fd5c5 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
7266aac 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
65fb4fc 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
5770ce8 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
c8620d6 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
2be657c 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
2a34abe 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
654afb7 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 27, 2023
@ArtiomDivak
Add support for conf.d configuration files
d7de4a9 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 28, 2023
@ArtiomDivak
Add support for conf.d configuration files
8861456 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 28, 2023
@ArtiomDivak
Add support for conf.d configuration files
b8c402f 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 28, 2023
@ArtiomDivak
Add support for conf.d configuration files
e317bcf 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit to ArtiomDivak/BlueChi that referenced this issue Mar 28, 2023
@ArtiomDivak
Add support for conf.d configuration files
a0b5b49 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
mwperina pushed a commit to ArtiomDivak/BlueChi that referenced this issue Mar 29, 2023
@ArtiomDivak @mwperina
Add support for conf.d configuration files
5b1a363 
This is a follow-up of eclipse-bluechi#147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: eclipse-bluechi#148
Signed-off-by: Artiom Divak adivak@redhat.com
Signed-off-by: Artiom Divak <adivak@redhat.com>
ArtiomDivak added a commit that referenced this issue Mar 30, 2023
@ArtiomDivak
Add support for conf.d configuration files (#178)
015cc68 
This is a follow-up of #147 where it's suggested to use /etc/hirte/hirte.conf and /etc/hirte/agent.conf as configuration files, which could be modified by users to specify custom options.

But for automation it's not easy to parse current configuration file and save a new one with modified values, it would be much easier to use conf.d directory with custom user configuration files.

Here is the suggestion for the whole configuration files lineup for hirte manager:

    /usr/share/hirte/config/hirte-default.conf
        The base configuration file provided project defaults, which should not be modified by users
    /etc/hirte/hirte.conf
        The configurations file, where users can modified default values
    /etc/hirte/hirte.conf.d/
        Configuration directory where users might insert a configuration file (for example 99-custom-logging.conf)
        Only files with .conf suffix are used to load configuration changes
        Files in this directory are loaded in alphabetical order, so it's suggested to use number prefix to ease understanding of loading (for example 95-my-manager.conf and 99-custom-logging.conf)

Similar structure should be used also for hirte-agent:

    /usr/share/hirte-agent/config/hirte-default.conf
    /etc/hirte/agent.conf
    /etc/hirte/agent.conf.d/

Using above configuration files structure should also change the order of loading configurations files during hirte/hirte-agent startup:

    1)Load the default configuration values from /usr/share and store them to the configuration hash map
    2)Load user customizations from /etc/hirte/{hirte|agent}.conf and overwrite updated values in the configuration hash map
    3)Load user customizations files from /etc/hirte/{hirte|agent}.conf.d/ by alphabetical order and overwrite updated values in the configuration hash map
    4)Check if all required options have a valid value

Fixes: #148 

Signed-off-by: Artiom Divak <adivak@redhat.com>
This was referenced Apr 21, 2023
Merged
Merged
@mwperina mwperina mentioned this issue May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtiomDivak ArtiomDivak

Labels
jira Issues that are synced to Jira
Projects
None yet
Milestone
No milestone
3 participants
@mwperina @engelmi @ArtiomDivak