-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved error and info logs when loading configurations #300
improved error and info logs when loading configurations #300
Conversation
Hi Douglas, The PR #253 changed this a bit, but still following rules applies:
The only planned changes around configuration are described at #301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the error message content change it looks good to me
Hello @mwperina Thanks for sharing the info. I am not saying the RFEs created to manage the config files are incorrect. I am just seeing some improvements are possible here. However, let's move forward with @engelmi work. I will work this week to prepare a proof of concept and send a PR. Thanks guys! |
/retest |
Signed-off-by: Michael Engel <mengel@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This PR addresses #299