Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KeepAlive options to configuration #674

Closed
engelmi opened this issue Dec 20, 2023 · 0 comments · Fixed by #673
Closed

Add KeepAlive options to configuration #674

engelmi opened this issue Dec 20, 2023 · 0 comments · Fixed by #673
Assignees
Labels
enhancement New feature or request jira Issues that are synced to Jira
Milestone

Comments

@engelmi
Copy link
Member

engelmi commented Dec 20, 2023

As #652 demonstrates, being able to configure BlueChi's behavior in regards to networking issues. The KeepAlive mechanism is one part that can be tweaked for this.

Currently, only tcp_keepalive_idle and tcp_keepalive_intvl are being set with hard-coded defaults. tcp_keepalive_probes is missing. It would be great to add the missing option and make all of them configurable - preserving the defaults that are used right now via hard-coded defaults.

@engelmi engelmi added enhancement New feature or request jira Issues that are synced to Jira labels Dec 20, 2023
@engelmi engelmi added this to the v0.7 milestone Dec 20, 2023
@engelmi engelmi self-assigned this Dec 20, 2023
engelmi added a commit that referenced this issue Dec 20, 2023
Fixes: #674
Relates to: #652

In order to enable users of BlueChi to tweak its networking
behavior, the TCP KeepAlive options - which were set anyway
to internally defined defaults - are made configurable. In
addition, a new struct has been introduced to bundle socket
related options.
Also, parts of the bus utils which are related to socket
functionality were moved to the respective socket source
files.

Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi added a commit that referenced this issue Dec 20, 2023
Fixes: #674
Relates to: #652

In order to enable users of BlueChi to tweak its networking
behavior, the TCP KeepAlive options - which were set anyway
to internally defined defaults - are made configurable. In
addition, a new struct has been introduced to bundle socket
related options.
Also, parts of the bus utils which are related to socket
functionality were moved to the respective socket source
files.

Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi added a commit that referenced this issue Dec 20, 2023
Fixes: #674
Relates to: #652

In order to enable users of BlueChi to tweak its networking
behavior, the TCP KeepAlive options - which were set anyway
to internally defined defaults - are made configurable. In
addition, a new struct has been introduced to bundle socket
related options.
Also, parts of the bus utils which are related to socket
functionality were moved to the respective socket source
files.

Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi added a commit that referenced this issue Dec 21, 2023
Fixes: #674
Relates to: #652

In order to enable users of BlueChi to tweak its networking
behavior, the TCP KeepAlive options - which were set anyway
to internally defined defaults - are made configurable. In
addition, a new struct has been introduced to bundle socket
related options.
Also, parts of the bus utils which are related to socket
functionality were moved to the respective socket source
files.

Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi added a commit that referenced this issue Dec 21, 2023
Fixes: #674
Relates to: #652

In order to enable users of BlueChi to tweak its networking
behavior, the TCP KeepAlive options - which were set anyway
to internally defined defaults - are made configurable. In
addition, a new struct has been introduced to bundle socket
related options.
Also, parts of the bus utils which are related to socket
functionality were moved to the respective socket source
files.

Signed-off-by: Michael Engel <mengel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira Issues that are synced to Jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant