added TCP KeepAlive options to configuration #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
requested review from
alexlarsson,
mkemel and
rhatdan
as code owners
engelmi
force-pushed
the
add-keepalive-config-options
branch
2 times, most recently
from
74ff3ef
to
ed77ddd
Compare
engelmi
force-pushed
the
add-keepalive-config-options
branch
from
ed77ddd
to
a9437b6
Compare
|
Added a few unit tests for the new functionality as well. |
engelmi
force-pushed
the
add-keepalive-config-options
branch
from
a9437b6
to
28ae09e
Compare
Fixes: #674 Relates to: #652 In order to enable users of BlueChi to tweak its networking behavior, the TCP KeepAlive options - which were set anyway to internally defined defaults - are made configurable. In addition, a new struct has been introduced to bundle socket related options. Also, parts of the bus utils which are related to socket functionality were moved to the respective socket source files. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
add-keepalive-config-options
branch
from
28ae09e
to
e0172c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #674
Relates to: #652
In order to enable users of BlueChi to tweak its networking behavior, the TCP KeepAlive options - which were set anyway to internally defined defaults - are made configurable. In addition, a new struct has been introduced to bundle socket related options.
Also, parts of the bus utils which are related to socket functionality were moved to the respective socket source files.