Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover function proxy_monitor_send_error from controller/proxy_monitor.c by tests #797

Closed
mwperina opened this issue Mar 6, 2024 · 1 comment · Fixed by #816
Closed

Cover function proxy_monitor_send_error from controller/proxy_monitor.c by tests #797

mwperina opened this issue Mar 6, 2024 · 1 comment · Fixed by #816
Assignees
@engelmi
Labels
enhancement New feature or request jira Issues that are synced to Jira
Milestone
v0.8

Comments

@mwperina
Copy link
Member

mwperina commented Mar 6, 2024

Cover function proxy_monitor_send_error by either unit or integration tests.
@mwperina mwperina added the enhancement New feature or request label Mar 6, 2024
@mwperina mwperina added this to the v0.8 milestone Mar 6, 2024
@engelmi
Copy link
Member

engelmi commented Mar 7, 2024

This is being called in two cases:

  • the requesting service requires the proxy on a node that isn't connected to the controller
  • OOM occurs further down in the execution

Since the second case can't be tested easily, testing the first case is sufficient.

@engelmi engelmi self-assigned this Mar 7, 2024
@engelmi engelmi added the jira Issues that are synced to Jira label Mar 7, 2024
@engelmi engelmi mentioned this issue Mar 7, 2024
Closed
engelmi added a commit to engelmi/bluechi that referenced this issue Mar 8, 2024
@engelmi
added integration test for proxy on non-existing node
7618165 
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi mentioned this issue Mar 8, 2024
Merged
mwperina pushed a commit to engelmi/bluechi that referenced this issue Mar 8, 2024
@engelmi @mwperina
added integration test for proxy on non-existing node
b323eb4 
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
mwperina pushed a commit to engelmi/bluechi that referenced this issue Mar 8, 2024
@engelmi @mwperina
added integration test for proxy on non-existing node
f4a96fb 
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
mwperina pushed a commit to engelmi/bluechi that referenced this issue Mar 8, 2024
@engelmi @mwperina
added integration test for proxy on non-existing node
0fe9161 
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
mwperina pushed a commit to engelmi/bluechi that referenced this issue Mar 11, 2024
@engelmi @mwperina
added integration test for proxy on non-existing node
73cd404 
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi added a commit to engelmi/bluechi that referenced this issue Mar 11, 2024
@engelmi
added integration test for proxy on non-existing node
f5d7ee9 
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engelmi engelmi

Labels
enhancement New feature or request jira Issues that are synced to Jira
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

added integration test for proxy on non-existing node engelmi/bluechi
2 participants
@mwperina @engelmi