Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added integration test for proxy on non-existing node #816

Merged

Conversation

engelmi
Copy link
Member

@engelmi engelmi commented Mar 8, 2024

Fixes: #788
Fixes: #797

Adds an integration test to verify that a requesting a proxy service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the requesting service will still be active, but the template service for the proxy is in a failed state.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina force-pushed the add-integration-test-proxy-no-node branch from 7618165 to b323eb4 Compare March 8, 2024 17:02
@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

coverage: 80.338% (+0.3%) from 80.081%
when pulling f5d7ee9 on engelmi:add-integration-test-proxy-no-node
into 49db3ae on eclipse-bluechi:main.

@mwperina mwperina force-pushed the add-integration-test-proxy-no-node branch 3 times, most recently from 0fe9161 to 73cd404 Compare March 11, 2024 08:10
Fixes: eclipse-bluechi#788
Fixes: eclipse-bluechi#797

Adds an integration test to verify that a requesting a proxy
service on a non-existing node fails.
By using Wants=, a weak dependency is used so that the
requesting service will still be active, but the template
service for the proxy is in a failed state.

Signed-off-by: Michael Engel <mengel@redhat.com>
@engelmi engelmi force-pushed the add-integration-test-proxy-no-node branch from 73cd404 to f5d7ee9 Compare March 11, 2024 08:43
@engelmi engelmi merged commit 147e053 into eclipse-bluechi:main Mar 11, 2024
9 of 17 checks passed
@engelmi engelmi deleted the add-integration-test-proxy-no-node branch June 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants