Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Fedora packaging fixes #220

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Additional Fedora packaging fixes #220

merged 4 commits into from
Mar 22, 2023

Conversation

mwperina
Copy link
Member

  • Align source archive content with the one generated on GitHub
  • Replace tabs with spaces in the spec file
  • Align source code license with RPM license
  • Move DBus configuration from /etc to /usr/share

@mwperina
Align source archive content with the one generated on GitHub
2a550cc 
GitHub automatically generates source archive into "<name>-<version>"
top level directory, so we need align our archive which we generate
during our RPM build on GitHub.

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Replace tabs with spaces in the spec file
306804a 
Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Align source code license with RPM license
1c686ef 
We are using in the source code `GPL-2.0-or-later` so we need to use
`GPLv2` in the spec file.

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Move DBus configuration from /etc to /usr/share
68cf6fe 
Move DBus configuration files from `/etc/dbus-1/system.d/` to
`/usr/share/dbus-1/system.d`

Signed-off-by: Martin Perina <mperina@redhat.com>
engelmi
engelmi approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 78739d5 into eclipse-bluechi:main Mar 22, 2023
@mwperina mwperina deleted the additional-fedora-spec-fixes branch March 22, 2023 13:58
@engelmi engelmi mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelmi engelmi engelmi approved these changes

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@mkemel mkemel Awaiting requested review from mkemel mkemel is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@sdunnagan sdunnagan Awaiting requested review from sdunnagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwperina @engelmi