Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dnf upgrade when building the integration-test-base image #327

Merged
merged 1 commit into from
May 31, 2023
Merged

added dnf upgrade when building the integration-test-base image #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/containers/integration-test-base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ FROM quay.io/centos/centos:stream9

RUN dnf install -y dnf-plugin-config-manager

RUN dnf upgrade --refresh -y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we are already getting the latest CS9 container as a base here, so does it mean that the container might not be synced with the actual content of CS9 repos? Meaning that for example container is recreated only once per day while repos are updated regularly during the day?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have any control over the base image we cannot guaranty what's in it and what will be there the following day. As a result using dnf upgrade is the right way to go.
I would argue that this line could have been merged with the next one, making it a single layer. But, since it's a test image, it's not that important.


RUN dnf install \
policycoreutils-python-utils \
selinux-policy \
Expand Down