agent: add support to FQDN in ManagerHost

[dougsland]

GitHub-Issue: #276

[engelmi]

Looks great! I only have a few nit-picky comments.

And thanks for adding unit tests! Having one test file for one function under test seems better than one test file containing multiple (as it is currently - we'll have to refactor that).

[dougsland]

@engelmi ouch not sure how to access the logs from GitHub actions:

>>> MALLOC_PERTURB_=199 valgrind --leak-check=full --error-exitcode=1 --track-origins=yes /__w/hirte/hirte/builddir/src/libhirte/test/common/network/get_address_test

Maybe setup a valgrind env here?

[root@node1 hirte]# meson test -C builddir
ninja: Entering directory `/root/hirte/builddir'
ninja: no work to do.
1/8 cfg_test                    OK              0.03s
2/8 list_test                   OK              0.03s
3/8 parse-util_test             OK              0.03s
4/8 string-util_test            OK              0.03s
5/8 isIPv4Addr_test             OK              0.02s
6/8 isIPv6Addr_test             OK              0.02s
7/8 assemble_tcp_address        OK              0.01s
8/8 get_address_test            OK              0.02s

Ok:                 8
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Full log written to /root/hirte/builddir/meson-logs/testlog.txt

[mwperina]

@engelmi ouch not sure how to access the logs from GitHub actions:

Maybe #346 will help here

[pypingou]

Could you rebase to see if the new CI config helps?

[dougsland]

@engelmi ouch not sure how to access the logs from GitHub actions:

Maybe #346 will help here

cool, let me try.

[dougsland]

do we have tools commands like /retest? @pypingou @mwperina

/retest

[dougsland]

@mwperina @engelmi @rhatdan @pypingou (and others) ready for review and fly.

[engelmi]

do we have tools commands like /retest? @pypingou @mwperina

/retest

No, at least there is no bot configured that would pick up those commands. We are using "plain" github actions. So if a step fails, its best to click on "Details" - on the following page you can trigger a re-run manually, look at the CI logs and download artifacts (like the unit test logs).

[engelmi]

LGTM