Fix detecting architecture within container builds #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
We need to detect the architecture to provide the correct DNF repository with BlueChi RPMs. Fixes: eclipse-bluechi#437 Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
force-pushed
the
set-arch-for-containerfile-2
branch
from
f1f4765 to
3eb7599
Compare
|
LGTM |
dougsland
approved these changes
Aug 10, 2023
mwperina
added a commit
to mwperina/bluechi
that referenced
this pull request
Nov 7, 2023
Passing `--arch` parameter to `podman build` in `tests/scripts/tests-setup.sh` is no longer needed after eclipse-bluechi#441 being merged. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/bluechi
that referenced
this pull request
Nov 8, 2023
Passing `--arch` parameter to `podman build` in `tests/scripts/tests-setup.sh` is no longer needed after eclipse-bluechi#441 being merged. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
to mwperina/bluechi
that referenced
this pull request
Nov 9, 2023
Passing `--arch` parameter to `podman build` in `tests/scripts/tests-setup.sh` is no longer needed after eclipse-bluechi#441 being merged. Signed-off-by: Martin Perina <mperina@redhat.com>
mwperina
added a commit
that referenced
this pull request
Nov 9, 2023
Passing `--arch` parameter to `podman build` in `tests/scripts/tests-setup.sh` is no longer needed after #441 being merged. Signed-off-by: Martin Perina <mperina@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to detect the architecture to provide the correct DNF repository
with BlueChi RPMs.
Fixes: #437
Signed-off-by: Martin Perina mperina@redhat.com