Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support for packit builds #488

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Introduce support for packit builds #488

merged 3 commits into from
Nov 9, 2023

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Aug 22, 2023 •
edited
Loading

Introduces ability to build RPMs using packit and run integration tests within testing farm.

Current Github CI to build RPMs and run integrations tests will be remove in follow up PR.

Fixes: #452

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'bluechi': {'value': {'create-archive': ['Unknown field.'], 'get-current-version': ['Unknown field.']}}})}}, 'packages': defaultdict(<class 'dict'>, {'bluechi': {'value': {'create-archive': ['Unknown field.'], 'get-current-version': ['Unknown field.']}}})}).

For more info, please check out the documentation or contact the Packit team.

@mwperina
Copy link
Member Author

/packit build

@mwperina mwperina force-pushed the test-packit branch 9 times, most recently from 3e7be5a to 2c73aa1 Compare August 23, 2023 14:24
@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'job': ['Invalid enum member copr_build_pr']}, 1: {'job': ['Invalid enum member test_pr']}, 2: {'job': ['Invalid enum member copr_build_snapshot']}}}).

For more info, please check out the documentation or contact the Packit team.

@mwperina mwperina force-pushed the test-packit branch 8 times, most recently from f3922f3 to 607c1a3 Compare August 24, 2023 15:34
@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {1: {'packages': defaultdict(<class 'dict'>, {'bluechi': {'value': {'env': ['Not a valid mapping type.']}}})}}}).

For more info, please check out the documentation or contact the Packit team.

@mwperina mwperina force-pushed the test-packit branch 5 times, most recently from 6757445 to 9c6b31f Compare August 25, 2023 12:29
@mwperina
Copy link
Member Author

/packit test

@mwperina mwperina force-pushed the test-packit branch 2 times, most recently from b67f498 to 705877b Compare August 25, 2023 14:12
@mwperina mwperina force-pushed the test-packit branch 2 times, most recently from 9ff6870 to 73dc78a Compare October 5, 2023 09:49
@mwperina
Copy link
Member Author

/packit test

@mwperina mwperina changed the title [WIP] Introduce support for packit builds Introduce support for packit builds Nov 6, 2023
@mwperina mwperina marked this pull request as ready for review November 6, 2023 12:55
@mwperina mwperina force-pushed the test-packit branch 2 times, most recently from d29cf9f to 68780ee Compare November 7, 2023 08:26
@mwperina
Copy link
Member Author

mwperina commented Nov 7, 2023

/packit build

@mwperina
Copy link
Member Author

mwperina commented Nov 7, 2023

/packit test

@mwperina
Copy link
Member Author

mwperina commented Nov 7, 2023

/packit build

@mwperina
Copy link
Member Author

mwperina commented Nov 7, 2023

/packit test

1 similar comment
@mwperina
Copy link
Member Author

mwperina commented Nov 7, 2023

/packit test

engelmi
engelmi reviewed Nov 7, 2023
View reviewed changes
tests/containers/integration-test-packit Outdated Show resolved Hide resolved
tests/scripts/tests-setup.sh Show resolved Hide resolved
tests/scripts/tests-setup.sh Outdated Show resolved Hide resolved
@mwperina mwperina force-pushed the test-packit branch 2 times, most recently from e30a657 to c28e213 Compare November 8, 2023 14:29
engelmi
engelmi approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@engelmi engelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina
Remove unneeded --arch parameter in test container builds
f08a834 
Passing `--arch` parameter to `podman build` in
`tests/scripts/tests-setup.sh` is no longer needed after
eclipse-bluechi#441 being merged.

Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Introduce support for packit builds
56256b9 
- Adapt our RPM build scripts to be usable in packit
- Add support to build RPMs for the most important architectures when PR
  is added/updated
- Add support to build RPMs for all supported platforms and save produced
  RPMs into our COPR repository

Fixes: eclipse-bluechi#452
Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina
Introduce support for packit testing farm
b04e580 
- Adapt our integration tests to be executable by packit in the testing
  farm
- Add support to execute integration tests after RPMs are built when PR
  is added/updated

Fixes: eclipse-bluechi#452
Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina mwperina merged commit cb5e10f into eclipse-bluechi:main Nov 9, 2023
17 checks passed
@mwperina mwperina deleted the test-packit branch November 9, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelmi engelmi engelmi approved these changes

@Yarboa Yarboa Yarboa approved these changes

@pypingou pypingou Awaiting requested review from pypingou

@alexlarsson alexlarsson Awaiting requested review from alexlarsson alexlarsson is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate current COPR snapshot builds to packit
3 participants
@mwperina @Yarboa @engelmi