Time graph filtering and collapsing not working properly. #1132
Comments
PatrickTasse
added a commit
to PatrickTasse/theia-trace-extension
that referenced
this issue
Oct 21, 2024
Update the filtering of empty nodes to include visible nodes even if any of their parent is filtered-out. Recursively replace filtered-out nodes by their visible children, if any, but only if the filtered-out parent node is not collapsed. In TimeGraphOutputComponent update the arrows layer after empty nodes have been determined, and filter out empty nodes from the rowIds passed to the arrows layer. Fixes eclipse-cdt-cloud#1132 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse
added a commit
to PatrickTasse/theia-trace-extension
that referenced
this issue
Oct 24, 2024
Update the filtering of empty nodes to include visible nodes even if any of their parent is filtered-out. Recursively replace filtered-out nodes by their visible children, if any, but only if the filtered-out parent node is not collapsed. In TimeGraphOutputComponent update the arrows layer after empty nodes have been determined, and filter out empty nodes from the rowIds passed to the arrows layer. Update getIndexOfNode() in utils to consider the list of empty nodes. Fix names of selectedRow and multiSelectedRows in TableBodyProps. Fixes eclipse-cdt-cloud#1132 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse
added a commit
to PatrickTasse/theia-trace-extension
that referenced
this issue
Oct 29, 2024
Update the filtering of empty nodes to include visible nodes even if any of their parent is filtered-out. Recursively replace filtered-out nodes by their visible children, if any, but only if the filtered-out parent node is not collapsed. In TimeGraphOutputComponent update the arrows layer after empty nodes have been determined, and filter out empty nodes from the rowIds passed to the arrows layer. Update getIndexOfNode() in utils to consider the list of empty nodes. Fix names of selectedRow and multiSelectedRows in TableBodyProps. Fixes eclipse-cdt-cloud#1132 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
PatrickTasse
added a commit
that referenced
this issue
Oct 29, 2024
Update the filtering of empty nodes to include visible nodes even if any of their parent is filtered-out. Recursively replace filtered-out nodes by their visible children, if any, but only if the filtered-out parent node is not collapsed. In TimeGraphOutputComponent update the arrows layer after empty nodes have been determined, and filter out empty nodes from the rowIds passed to the arrows layer. Update getIndexOfNode() in utils to consider the list of empty nodes. Fix names of selectedRow and multiSelectedRows in TableBodyProps. Fixes #1132 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a filter is applied, only the matching root elements (below the trace root) are visible. All children of a non-matching parent are ignored.
When a non-matching node is filtered-out, it should be replaced by its matching children, recursively. The children of collapsed nodes should not be considered.
When updating the arrows layer, it is not considering filtered-out nodes so the arrows can start or end at the wrong node position or in blank space.
Rows that change y-position because preceding node is filtered-out or collapsed are remaining at the previous position. They should be updated. If possible avoid refreshing the row from the server if the current model is still valid. If no row needs to be fetched from the server then arrows may still need to be refreshed.
When a filter is applied and a search string is entered, all rows are re-filtered. This should only be done when a filter is added or removed, not when search string is modified.
The text was updated successfully, but these errors were encountered: