Fix time graph filtering and collapsing #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
requested changes
Oct 21, 2024
|
I noticed some issues when selection rows when filtering is ongoing and after all rows are filtered out. When filtering is ongoing, and I click on the tree, it seems that the tree is scrolling to a different location:
When filtering is finished, the selection is not synced correctly from tree to graph. See video when selecting with left mouse button: |
bhufmann
requested changes
Oct 28, 2024
bhufmann
requested changes
Oct 29, 2024
| @@ -34,7 +34,7 @@ export class TableBody extends React.Component<TableBodyProps> { | |||
| if (!this.props.nodes) { | |||
| return undefined; | |||
| } | |||
|
|
|||
| console.log('TableBody.render() selectedRow:'+this.props.selectedRow+' multiSelectedRows:'+this.props.multiSelectedRows); | |||
Update the filtering of empty nodes to include visible nodes even if any of their parent is filtered-out. Recursively replace filtered-out nodes by their visible children, if any, but only if the filtered-out parent node is not collapsed. In TimeGraphOutputComponent update the arrows layer after empty nodes have been determined, and filter out empty nodes from the rowIds passed to the arrows layer. Update getIndexOfNode() in utils to consider the list of empty nodes. Fix names of selectedRow and multiSelectedRows in TableBodyProps. Fixes eclipse-cdt-cloud#1132 Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the filtering of empty nodes to include visible nodes even if any of their parent is filtered-out. Recursively replace filtered-out nodes by their visible children, if any, but only if the filtered-out parent node is not collapsed.
In TimeGraphOutputComponent update the arrows layer after empty nodes have been determined, and filter out empty nodes from the rowIds passed to the arrows layer.
Fixes #1132