Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of entries returned by time graph data providers not kept #129

Closed
bhufmann opened this issue Sep 25, 2020 · 0 comments
Closed

Order of entries returned by time graph data providers not kept #129

bhufmann opened this issue Sep 25, 2020 · 0 comments
Labels
bug Something isn't working Theia UI frontend
Milestone
MVP

Comments

@bhufmann
Copy link
Collaborator

Time Graph tree entries are sorted by id in the UI and the order returned by the time data provider is not kept. Since the ids, are arbitrary, it should not be used for sorting.

In my custom trace I have a data provider that returns the following order:

parentA (parentId: -1, id: 3)
childA (parentId:3, id 10)
childB (parentId:3, id 5)
parentB (parentId: -1, id: 2)
childC (parentId:2, id 20)
childD (parentId:2, id 15)

In the view it looks like:

parentB (parentId: -1, id: 2)
childD (parentId:2, id 15)
childC (parentId:2, id 20)
parentA (parentId: -1, id: 3)
childB (parentId:3, id 5)
childA (parentId:3, id 10)
@bhufmann bhufmann added bug Something isn't working Theia UI frontend labels Sep 25, 2020
@bhufmann bhufmann added this to the First MVP milestone Sep 25, 2020
bhufmann added a commit that referenced this issue Oct 16, 2020
@bhufmann
#129: Keep order of tree entries returned by the data provider
972030d 
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
hriday-panchasara pushed a commit to hriday-panchasara/theia-trace-extension that referenced this issue Nov 10, 2021
@bhufmann @hriday-panchasara
eclipse-cdt-cloud#129: Keep order of tree entries returned by the dat…
919d495 
…a provider

Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
@marcdumais-work marcdumais-work mentioned this issue Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Theia UI frontend
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@bhufmann