Test publish: latest (v0.2.0) npm packages #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running "lerna version" to create release commits, it will change indentation to 4 spaces. Unless we already have the same, it will do the change, which we do not want as part of the release commit. This is a one-off. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
|
The following 1 GitHub releases will be created once this pull request got merged. Release v0.2.0 with changes since v0.0.0
|
|
Oops - there are apparent build issues to investigate - back to draft |
|
Ah, I think that with this change, we end-up somehow pulling |
marcdumais-work
force-pushed
the
test-publish-latest
branch
from
c23c754 to
4bc6018
Compare
|
The following 1 GitHub releases will be created once this pull request got merged. Release v0.2.0 with changes since v0.0.0
|
|
It's a bit strange, but I still had build issues after publishing a new version of |
marcdumais-work
changed the title
bhufmann
approved these changes
Mar 21, 2024
|
Thanks for the review! Fingers crossed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests the recently added CI publishing infrastructure by attempting to publish v0.2.0 of the 3 npm packages in this repo.
When I ran "yarn version:minor" I noticed that it massaged the
package.jsonfiles andlerna.json, changing indentation from 2 to 4 and making sure there was a terminating line at the end of the files. To make things cleaner, I added a commit that replicated these changes, before the release commit.