Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chart and filter field backgrounds a darker colour in dark theme #282

Closed
ebugden opened this issue Mar 1, 2021 · 1 comment
Closed

Make chart and filter field backgrounds a darker colour in dark theme #282

ebugden opened this issue Mar 1, 2021 · 1 comment
Assignees
@thefinaljob
Labels
good first issue Good for newcomers Theia UI frontend UX User experience improvement
Milestone
MVP

Comments

@ebugden
Copy link
Contributor

ebugden commented Mar 1, 2021 •
edited
Loading

In dark theme, the contrast between the chart background and the tab background should be reduced (same for the filter background). This makes the data stand out more and draw the user's eye towards the data.

  • New dark theme filter and background colours should have a similar difference in brightness to the existing light theme background colours.
  • Tip: Colorizer.org is useful for easily adjusting colours along different scales
Current Light Theme Proposed Dark Theme
Difference in brightness (HSB): ~2 image Difference in brightness (HSB): ~2 image
Background: #ffffff image Chart background: #f4f7fb image Chart background: #232323 image Tab background: #1e1e1e image

image

Comparison of darker and lighter backgrounds:

Current backgrounds (lighter) Proposed backgrounds (darker)
Difference in brightness (HSB): ~13 image Difference in brightness (HSB): ~2 image
Chart background: #3f3f3f image Tab background: #1e1e1e image Chart background: #232323 image Tab background: #1e1e1e image
@ebugden ebugden added Theia UI frontend UX User experience improvement labels Mar 1, 2021
@ebugden ebugden added this to the MVP milestone Mar 1, 2021
@ebugden ebugden mentioned this issue Mar 2, 2021
Closed
@ebugden ebugden added the good first issue Good for newcomers label May 4, 2021
@ebugden ebugden changed the title Make chart and filter field backgrounds a darker colour Make chart and filter field backgrounds a darker colour in dark theme Jun 8, 2021
@ebugden ebugden mentioned this issue Jul 23, 2021
Merged
thefinaljob added a commit to thefinaljob/theia-trace-extension that referenced this issue Jul 28, 2021
@thefinaljob
Make chart background color darker as outlined in issue eclipse-cdt-c…
9bb8835 
…loud#282

Signed-off-by: Nikolai Peram <nikolai_peram@outlook.com>
@ssmagula ssmagula mentioned this issue Aug 9, 2021
Merged
@ebugden ebugden mentioned this issue Aug 18, 2021
Closed
bhufmann pushed a commit that referenced this issue Aug 25, 2021
@thefinaljob @bhufmann
Make chart background color darker as outlined in issue #282
aa86ded 
Signed-off-by: Nikolai Peram <nikolai_peram@outlook.com>
@ebugden
Copy link
Contributor Author

ebugden commented Sep 7, 2021

Fixed by PR #382. (This issue should have been linked to the PR so that it was closed when the PR was merged.)

@ebugden ebugden closed this as completed Sep 7, 2021
paul-marechal pushed a commit to paul-marechal/theia-trace-extension that referenced this issue Sep 14, 2021
@thefinaljob @paul-marechal
Make chart background color darker as outlined in issue eclipse-cdt-c…
1862077 
…loud#282

Signed-off-by: Nikolai Peram <nikolai_peram@outlook.com>
hriday-panchasara pushed a commit to hriday-panchasara/theia-trace-extension that referenced this issue Nov 10, 2021
@thefinaljob @hriday-panchasara
Make chart background color darker as outlined in issue eclipse-cdt-c…
68b9d36 
…loud#282

Signed-off-by: Nikolai Peram <nikolai_peram@outlook.com>
@marcdumais-work marcdumais-work mentioned this issue Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thefinaljob thefinaljob

Labels
good first issue Good for newcomers Theia UI frontend UX User experience improvement
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@thefinaljob @ebugden