Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce contrast of grid lines #441

Closed
ssmagula opened this issue Aug 5, 2021 · 2 comments · Fixed by #442
Closed

Reduce contrast of grid lines #441

ssmagula opened this issue Aug 5, 2021 · 2 comments · Fixed by #442
Assignees

Comments

@ssmagula
Copy link

ssmagula commented Aug 5, 2021

Grid lines are much more common yet much less important than the data being visualized, and therefore grid lines should be about "one noticeable difference" in contrast from the background of the chart. The current chart background is #232323. I'm proposing we use these colors for horizontal and vertical grid lines:

  • #35373B for horizontal grid lines
  • #2B2E31 for vertical grid lines

This will yield a more subdued grid similar to this screenshot (click to view something closer to actual pixels):
image

Let's compare and contrast (pun intended!) that grid with this grid in the current implementation:
image

In the above example, the grid lines are much, much more prominent than the data itself.

Because the proposed grid lines are more subdued, in a future iteration we may want to supplement the grid by highlighting grid lines when the user mouses near a line or an intersection of lines. In the current iteration the user must click.

@MatthewKhouzam
Copy link
Contributor

Thanks, I think this can be tackled in the short term.

IbrahimFradj added a commit to IbrahimFradj/theia-trace-extension that referenced this issue Aug 5, 2021
 change the color of lineColor with #35373B for horizontal grid lines and #2B2E31 for vertical grid lines

Fixes eclipse-cdt-cloud#441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
@ebugden
Copy link
Contributor

ebugden commented Aug 18, 2021

Prerequisite: #282 (Merging PR #382)

IbrahimFradj added a commit to IbrahimFradj/theia-trace-extension that referenced this issue Aug 23, 2021
 change the color of lineColor with #35373B for horizontal grid lines , #2B2E31 for vertical grid lines and background with #232323

Fixes eclipse-cdt-cloud#441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
IbrahimFradj added a commit to IbrahimFradj/theia-trace-extension that referenced this issue Aug 23, 2021
 change the color of lineColor with #35373B for horizontal grid lines , #2B2E31 for vertical grid lines and background with #232323

Fixes eclipse-cdt-cloud#441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
IbrahimFradj added a commit to IbrahimFradj/theia-trace-extension that referenced this issue Aug 24, 2021
 change the color of lineColor with #35373B for horizontal grid lines , #2B2E31 for vertical grid lines and background with #232323

Fixes eclipse-cdt-cloud#441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
IbrahimFradj added a commit to IbrahimFradj/theia-trace-extension that referenced this issue Sep 8, 2021
 change the color of lineColor with #35373B for horizontal grid lines , #2B2E31 for vertical grid lines and background with #232323

Fixes eclipse-cdt-cloud#441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
bhufmann pushed a commit that referenced this issue Sep 15, 2021
 change the color of lineColor with #35373B for horizontal grid lines , #2B2E31 for vertical grid lines and background with #232323

Fixes #441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
hriday-panchasara pushed a commit to hriday-panchasara/theia-trace-extension that referenced this issue Nov 10, 2021
 change the color of lineColor with #35373B for horizontal grid lines , #2B2E31 for vertical grid lines and background with #232323

Fixes eclipse-cdt-cloud#441

Signed-off-by: Ibrahim Fradj <ibrahim.fradj@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants