trace-explorer: add to default layout #82
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: eclipse-cdt-cloud#80 The following commit adds the `Trace Explorer` to the default layout of the application. This will make the view more discoverable and accessible to end-users. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
bhufmann
approved these changes
Jun 19, 2020
|
I don't have the necessary permissions to the repo (reason in which I'm working from a fork) so please don't hesitate to merge if the changes are acceptable :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #80
The following commit adds the
Trace Explorerto the default layout of the application.Adding the view to the default layout will make it more discoverable and accessible to end-users, and can later be automatically opened if a trace is identified.
How to test
yarn && (cd browser-app && yarn start)Reset Workbench Layout(using the command palette ctrlcmd+shift+p)
(the command resets the layout to it's default (without local-storage storing the previous layout))
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com