Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #1059

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Mar 21, 2024

During the recent first automated release, we noticed that there's an extra step to be done in this repository: the requested version of "theia-traceviewer" needs to be updated in the example applications.

I think this does not happen automatically, even though the example applications are part of the lerna workspace, because of our current .gitignore file, which ignores these folders.

@marcdumais-work marcdumais-work marked this pull request as draft March 21, 2024 19:38
During the recent first automated release, we noticed that there's an
extra step to be done in this repository. It's because the version of
"theia-traceviewer" needs to be updated in the example applications.

I think this does not happen automatically, even though the example
applications are part of the lerna workspace, because of our current
.gitignore file, which ignores these folders.

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work marcdumais-work force-pushed the update-release-instructions branch from 67758d0 to 573805a Compare March 21, 2024 19:40
@marcdumais-work marcdumais-work marked this pull request as ready for review March 21, 2024 19:41
@marcdumais-work marcdumais-work merged commit 5115472 into master Mar 21, 2024
5 of 6 checks passed
@marcdumais-work marcdumais-work deleted the update-release-instructions branch March 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants