Events Table search filter persists when scrolling horizontally #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankusht-work
force-pushed
the
Issue/841
branch
from
e3f73aa to
4d52749
Compare
Signed-off-by: Ankush-Tyagi <ankush.tyagi@ericsson.com>
ankusht-work
force-pushed
the
Issue/841
branch
from
4d52749 to
cc5f425
Compare
bhufmann
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scrolling horizontally in the ag-grid table the SearchFilterRenderer components are unmounted when out of view and then created again when scrolled back into view. This patch adds the filterModel as a prop to the SearchFilterRenderer in order to set a default value when it is created again.
Fixes #841
Signed-off-by: Ankush-Tyagi ankush.tyagi@ericsson.com