Center X axis labels in relation to tick #440
Assignees
Comments
Rodrigoplp-work
pushed a commit
to Rodrigoplp-work/timeline-chart
that referenced
this issue
Aug 12, 2021
Currently the labels of the x-axis are aligned to the left, 5 pixels after their corresponding tick in the axis. This commit centers the labels according to their ticks. The position of the text is calculated by using the position of the tick, minus half the width of the text. Fixes [issue 440 in theia-ide/theia-trace-extension](eclipse-cdt-cloud/theia-trace-extension#440). Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
PatrickTasse
pushed a commit
to eclipse-cdt-cloud/timeline-chart
that referenced
this issue
Aug 19, 2021
Currently the labels of the x-axis are aligned to the left, 5 pixels after their corresponding tick in the axis. This commit centers the labels according to their ticks. The position of the text is calculated by using the position of the tick, minus half the width of the text. Fixes [issue 440 in theia-ide/theia-trace-extension](eclipse-cdt-cloud/theia-trace-extension#440). Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
Rodrigoplp-work
added a commit
to Rodrigoplp-work/theia-trace-extension
that referenced
this issue
Aug 25, 2021
Updates dependencies to apply fix for X axis labels. Fixes: eclipse-cdt-cloud#440. Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
bhufmann
pushed a commit
that referenced
this issue
Aug 25, 2021
Updates dependencies to apply fix for X axis labels. Fixes: #440. Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
paul-marechal
pushed a commit
to paul-marechal/theia-trace-extension
that referenced
this issue
Sep 14, 2021
Updates dependencies to apply fix for X axis labels. Fixes: eclipse-cdt-cloud#440. Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
hriday-panchasara
pushed a commit
to hriday-panchasara/theia-trace-extension
that referenced
this issue
Nov 10, 2021
Updates dependencies to apply fix for X axis labels. Fixes: eclipse-cdt-cloud#440. Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Values on the X and Y axes are frequently centered in relation to a tick that marks the value on the chart.
The Y Axis does follow this convention, however, in the current implementation of Trace Viewer, at least some time stamps on the X axis are left-aligned with a tick mark, with about 3-4 px of padding to the left of the label. When zooming in and out, the tick marks on the right side of the label move closer and farther from the label, which can lead to situations where it is not entirely clear which tick mark relates to a given label, for example:
An example with X axis labels centered on ticks is below: (click to view something closer to actual pixels)
Would centering the label over / under the tick mark make it easier to associate labels with ticks, no matter how the chart is zoomed?
The text was updated successfully, but these errors were encountered: