Center x-axis labels #150
Merged
Center x-axis labels #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the labels of the x-axis are aligned to the left, 5 pixels after their corresponding tick in the axis. This commit centers the labels according to their ticks. The position of the text is calculated by using the position of the tick, minus half the width of the text. Fixes [issue 440 in theia-ide/theia-trace-extension](eclipse-cdt-cloud/theia-trace-extension#440). Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca>
PatrickTasse
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the labels of the x-axis are aligned to the left, 5 pixels after their corresponding tick in the axis.
This commit centers the labels according to their ticks. The position of the text is calculated by using the position of the tick, minus half the width of the text.
Before the change:
After the change:
After the change in theia-trace-extension:
Fixes issue 440 in theia-ide/theia-trace-extension.
Signed-off-by: Rodrigo Pinto rodrigo.pinto@calian.ca