Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve selection visibility in time graphs #772

Closed
bhufmann opened this issue Jun 21, 2022 · 0 comments · Fixed by #788
Closed

Improve selection visibility in time graphs #772

bhufmann opened this issue Jun 21, 2022 · 0 comments · Fixed by #788
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Theia UI frontend

Comments

@bhufmann
Copy link
Collaborator

The selected row hard to discover in both dark and light mode. The selection color should be more visible. More over the row is not highlighted in the tree on the left side.

image
@bhufmann bhufmann added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Theia UI frontend labels Jun 21, 2022
williamsyang-work added a commit to williamsyang-work/theia-trace-extension that referenced this issue Jul 11, 2022
@williamsyang-work
Selected Row Visibility
9fed804 
Filter-tree and timeline-chart rows are now highlighted when selected.  Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa.  Highlighted color matches the current color theme.

Fixes: eclipse-cdt-cloud#772, eclipse-cdt-cloud#774

Signed-off-by: Will Yang <william.yang@ericsson.com>
@williamsyang-work williamsyang-work mentioned this issue Jul 11, 2022
Merged
williamsyang-work added a commit to williamsyang-work/theia-trace-extension that referenced this issue Jul 21, 2022
@williamsyang-work
Selected Row Visibility
852c437 
Filter-tree and timeline-chart rows are now highlighted when selected.  Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa.  Highlighted color matches the current color theme.

Fixes: eclipse-cdt-cloud#772, eclipse-cdt-cloud#774

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work added a commit to williamsyang-work/theia-trace-extension that referenced this issue Jul 21, 2022
@williamsyang-work
Selected Row Visibility
c86ffa3 
Filter-tree and timeline-chart rows are now highlighted when selected.  Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa.  Highlighted color matches the current color theme.

Fixes: eclipse-cdt-cloud#772, eclipse-cdt-cloud#774

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work added a commit to williamsyang-work/theia-trace-extension that referenced this issue Jul 26, 2022
@williamsyang-work
Selected Row Visibility
84c6faa 
Filter-tree and timeline-chart rows are now highlighted when selected.  Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa.  Highlighted color matches the current color theme.

Fixes: eclipse-cdt-cloud#772, eclipse-cdt-cloud#774

Signed-off-by: Will Yang <william.yang@ericsson.com>
williamsyang-work added a commit to williamsyang-work/theia-trace-extension that referenced this issue Jul 26, 2022
@williamsyang-work
Selected Row Visibility
a1ea126 
Filter-tree and timeline-chart rows are now highlighted when selected.  Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa.  Highlighted color matches the current color theme.

Fixes: eclipse-cdt-cloud#772, eclipse-cdt-cloud#774

Signed-off-by: Will Yang <william.yang@ericsson.com>
bhufmann pushed a commit that referenced this issue Jul 27, 2022
@williamsyang-work @bhufmann
Selected Row Visibility
c558e0d 
Filter-tree and timeline-chart rows are now highlighted when selected.  Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa.  Highlighted color matches the current color theme.

Fixes: #772, #774

Signed-off-by: Will Yang <william.yang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Theia UI frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Selected Row Visibility williamsyang-work/theia-trace-extension
1 participant
@bhufmann