-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selected Row Visibility #788
Selected Row Visibility #788
Conversation
build-and-test is failing because the timeline-chart changes I made are not implemented yet. |
@williamsyang-work I'm going to review this and related timeline-chart patch. |
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
852c437
to
c86ffa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. There seems to be build and linting error. Please fix a minor typo, build error and update the yarn.lock to include the new timeline-chart build.
const rowIndex = getIndexOfNode(id, listToTree(this.state.timegraphTree, this.state.columns), this.state.collapsedNodes); | ||
this.chartLayer.selectAndReveal(rowIndex); | ||
if (this.rowController.selectedRow?.id !== id) { | ||
// This hilights the left side if the row is loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: hilights -> highlights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved.
The build error is caused by some network problem. I'll re-trigger build once it's back to normal. The linting error is unrelated and you need to fix it. |
The network issue is fixed. There are build and lint errors remaining. @williamsyang-work please update this PR to fix the issues. |
783ab28
to
84c6faa
Compare
Filter-tree and timeline-chart rows are now highlighted when selected. Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa. Highlighted color matches the current color theme. Fixes: eclipse-cdt-cloud#772, eclipse-cdt-cloud#774 Signed-off-by: Will Yang <william.yang@ericsson.com>
Signed-off-by: Will Yang <william.yang@ericsson.com>
d8b9e27
to
867358e
Compare
Signed-off-by: Will Yang <william.yang@ericsson.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the improvement!
Filter-tree and timeline-chart rows are now highlighted when selected. Selecting a row in the timeline-chart selects the row in the filter-tree, and vice-versa. Highlighted color matches the current color theme.
Requires timeline-chart changes to function: Selected Row Visibility - PR #209
Fixes: #772, #774
Signed-off-by: Will Yang william.yang@ericsson.com