Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select and reveal of time graph rows should be consistently on top or middle of screen #773

Closed
bhufmann opened this issue Jun 21, 2022 · 0 comments · Fixed by eclipse-cdt-cloud/timeline-chart#211 or #836
Closed

Select and reveal of time graph rows should be consistently on top or middle of screen #773

bhufmann opened this issue Jun 21, 2022 · 0 comments · Fixed by eclipse-cdt-cloud/timeline-chart#211 or #836
Labels
Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart UX User experience improvement

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Jun 21, 2022 •
edited
Loading

#760 add support to select a time graph row automatically by synchronizing the selection in the events table. However, the location of the selected row is often at the bottom of the view (see https://user-images.githubusercontent.com/413424/172228226-6abc3070-9f8c-4d0b-a280-d866ab562fc0.gif). I think it would be better to either have it in the center of the view or alternatively on top. This will improve the visibility of the selected row.
@bhufmann bhufmann added UX User experience improvement timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart Theia UI frontend labels Jun 21, 2022
@bhufmann bhufmann changed the title Select and reveal of time graph rows should be consisitently on top or middle of screen Select and reveal of time graph rows should be consistently on top or middle of screen Jun 21, 2022
@williamsyang-work williamsyang-work mentioned this issue Aug 30, 2022
Merged
bhufmann added a commit to bhufmann/theia-trace-extension that referenced this issue Sep 13, 2022
@bhufmann
Upgrade to latest timeline-chart version
d8c1b80 
Fixes eclipse-cdt-cloud#773

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
@bhufmann bhufmann mentioned this issue Sep 13, 2022
Merged
bhufmann added a commit that referenced this issue Sep 13, 2022
@bhufmann
Upgrade to latest timeline-chart version
59d499b 
Fixes #773

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart UX User experience improvement
Projects
None yet
Milestone
No milestone
1 participant
@bhufmann