Select chart components from a selection in the events table #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is based on PR #746 and relevant code is move into this PR. |
|
|
PatrickTasse
requested changes
Jun 10, 2022
packages/react-components/src/components/table-output-component.tsx
Outdated
Show resolved
Hide resolved
PatrickTasse
requested changes
Jun 10, 2022
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
PatrickTasse
requested changes
Jun 16, 2022
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/src/components/timegraph-output-component.tsx
Outdated
Show resolved
Hide resolved
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
When selecting an event using the search capability in the events table broadcast the event details to other charts to select corresponding chart component. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
When using the keyboard to select an event, broadcast the event details to other charts to select corresponding chart component. Add support for arrow up/down key selection of events in the events table. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). Make sure that the properties view is updated with the last event selection. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
PatrickTasse
approved these changes
Jun 17, 2022
|
Fixes #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select corresponding chart components from the events table.
Clicking on a line in the events table will cause a chart like "Thread
Status" to scroll vertically to the row which has the element that
corresponds to the clicked event.
For each line in the timegraph tree, parse the metadata in the
TimeGraphEntry received from the server and try to find matches with the
key / values pairs of the clicked event. It will select the entry which
has the most matches.
When selecting an event using the search capability in the events table
broadcast the event details to other charts to select corresponding
chart component.
When using the keyboard to select an event, broadcast the event details
to other charts to select corresponding chart component.
Add support for arrow up/down key selection of events in the events
table.
Multi-line selection:
When extending the selection, only the first selected event will be
used to broadcast the selection .
Make sure that the properties view is updated with the last event
selection.
This PR requires the following pull requests:
https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246
eclipse-cdt-cloud/tsp-typescript-client#63
eclipse-cdt-cloud/timeline-chart#204
The corresponding Trace Server Protocol (TSP) update:
eclipse-cdt-cloud/trace-server-protocol#83
Signed-off-by: Rodrigo Pinto rodrigo.pinto@calian.ca
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com