Add metadata specification for TimeGraphEntry model #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
pushed a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 6, 2022
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the first selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
pushed a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 7, 2022
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
marco-miller
reviewed
Jun 7, 2022
|
@marco-miller I'll update it to indicate that the metadata field is optional. |
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
marco-miller
approved these changes
Jun 13, 2022
bhufmann
pushed a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 14, 2022
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
pushed a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 16, 2022
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
pushed a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jun 16, 2022
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
pushed a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Jun 17, 2022
Select corresponding chart components from the events table. Clicking on a line in the events table will cause a chart like "Thread Status" to scroll vertically to the row which has the element that corresponds to the clicked event. For each line in the timegraph tree, parse the metadata in the TimeGraphEntry received from the server and try to find matches with the key / values pairs of the clicked event. It will select the entry which has the most matches. When extending the selection, only the last selected event will be used to broadcast the selection (multi-line selection). This PR requires the following pull requests: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193246 eclipse-cdt-cloud/tsp-typescript-client#63 eclipse-cdt-cloud/timeline-chart#204 The corresponding Trace Server Protocol (TSP) update: eclipse-cdt-cloud/trace-server-protocol#83 Signed-off-by: Rodrigo Pinto <rodrigo.pinto@calian.ca> Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com