feat: reviewing pull requests blog post #23

dkwon17 · 2022-02-10T18:12:28Z

This PR contributes the blog post for: https://issues.redhat.com/browse/RHDEVDOCS-3522

Blog post preview: https://pr-check-23--che-blog.surge.sh/2022/02/16/@david.kwon-reviewing-pull-requests.html

Signed-off-by: David Kwon dakwon@redhat.com

dkwon17 · 2022-02-10T18:22:41Z

_posts/2022-01-11-contributing-for-the-first-time-to-a-project.adoc

@@ -74,7 +74,7 @@ Now you are ready for the first contribution. For GitHub, a dedicated plugin is
 image::/assets/img/contribute-to-a-project/github-plugin.png[[The 'GitHub' plugin]
 {empty}

-=== How can maintainers set up their projects to use {prod}?
+=== How can maintainers set up their projects to use {prod}? [[set-up-project]]


[[set-up-project]] was added so that this section can be linked here:

blog/_posts/2022-02-09-reviewing-pull-requests.adoc

Lines 21 to 23 in 0f35423

Please refer to these references on how to set up your project with {prod}:

* <<../../01/11/@ilya.buziuk-contributing-for-the-first-time-to-a-project#set-up-project,How can maintainers set up their projects to use Eclipse Che?>>

ibuziuk · 2022-02-11T09:59:16Z

@tstastna @themr0c please, review
we plan to have it published next week

_posts/2022-02-09-reviewing-pull-requests.adoc

ibuziuk

Great article, really like it
the only thing is that with che-incubator organization has enabled OAuth App access restrictions it is not possible to approve / merge PRs from IDE. I think we should consider disabling this restriction

_posts/2022-02-09-reviewing-pull-requests.adoc

dkwon17 · 2022-02-11T16:13:12Z

@ibuziuk thank you for the review, I have pushed the latest changes.

ibuziuk

Thanks, David
could you please update the file so that the publication date will be Feb 16th
Would be great to have it published on the hump day next week 👍

_posts/2022-02-09-reviewing-pull-requests.adoc

Signed-off-by: David Kwon <dakwon@redhat.com>

dkwon17 · 2022-02-12T01:36:44Z

could you please update the file so that the publication date will be Feb 16th

Updated to Feb 16 👍

themr0c · 2022-02-16T16:11:10Z

Is it OK to merge with the ECA failure? Else @dkwon17 would have to amend the commits in his branch to fix the email address.

* editing writing style and punctuation Signed-off-by: Jana Vrbkova <jvrbkova@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: David Kwon <dakwon@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update _posts/2022-02-16-reviewing-pull-requests.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> * Update 2022-02-16-reviewing-pull-requests.adoc quick typo fix Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com> Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com> Co-authored-by: David Kwon <dakwon@redhat.com>

dkwon17 requested a review from ibuziuk February 10, 2022 18:15

dkwon17 commented Feb 10, 2022

View reviewed changes

dkwon17 requested review from benoitf, l0rd and themr0c February 10, 2022 18:23

dkwon17 force-pushed the reviewing-pull-requests branch from 0f35423 to ef34674 Compare February 10, 2022 18:36

ibuziuk mentioned this pull request Feb 11, 2022

DevWorkspace articles publishing planning #19

Closed

ibuziuk reviewed Feb 11, 2022

View reviewed changes