Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: podman login into external docker registries on workspace start #1094

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Apr 11, 2024

What does this PR do?

feat: podman login into external docker registries on workspace start

What issues does this PR fix or reference?

eclipse-che/che#22863

Is it tested? How?

  1. Deploy Eclipse Che on OpenShift
  2. Configure valid credentials for a registry, for instance docker.io
  3. Configure invalid credentials for another registry, for instance for quay.io
  4. Start a workspace
  5. Check in the terminal the output
$ podman login docker.io
Authenticating with existing credentials for docker.io
Existing credentials are valid. Already logged in to docker.io
$ podman login quay.io
Username: ^Cprojects $ 
$ podman login image-registry.openshift-image-registry.svc:5000
Authenticating with existing credentials for image-registry.openshift-image-registry.svc:5000
Existing credentials are valid. Already logged in to image-registry.openshift-image-registry.svc:5000 

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Apr 11, 2024

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as draft April 11, 2024 09:43
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1094

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1094", name: che-dashboard}]}}]"

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as ready for review April 12, 2024 10:47
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1094

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1094", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1094

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1094", name: che-dashboard}]}}]"

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Apr 12, 2024
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1094

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1094", name: che-dashboard}]}}]"

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested a review from akurinnoy April 12, 2024 14:38
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1094

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1094", name: che-dashboard}]}}]"

@openshift-ci openshift-ci bot added the lgtm label Apr 15, 2024
Copy link

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 9d95008 into main Apr 15, 2024
15 of 16 checks passed
@tolusha tolusha deleted the 22863 branch April 15, 2024 07:15
@devstudio-release
Copy link

Build 3.14 :: dashboard_3.x/480: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.14 :: dashboard_3.x/480: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6509 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6466: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 60503950 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants