Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: podman login into external registries #1120

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: podman login into external registries #1120

merged 1 commit into from
May 31, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 29, 2024

What does this PR do?

fix: podman login into external registries

What issues does this PR fix or reference?

eclipse-che/che#22987

Is it tested? How?

Yes

Release Notes

Docs PR

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented May 29, 2024

Click here to review and test in web IDE: Contribute

@AObuchow
Copy link

@tolusha LGTM, I'd like to test but waiting for the build comment to be posted. Worst case, I'll try and build from your PR manually.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (9873276) to head (f4f69c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
- Coverage   89.60%   89.54%   -0.07%     
==========================================
  Files         408      408              
  Lines       41604    41604              
  Branches     2786     2776      -10     
==========================================
- Hits        37281    37254      -27     
- Misses       4297     4323      +26     
- Partials       26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1120

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1120", name: che-dashboard}]}}]"

Copy link

@AObuchow AObuchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as expected after testing changes.

projects $ podman login --get-login docker.io
aobuchow
projects $ podman login --get-login quay.io
aobuchow
projects $ 

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, AObuchow, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 0ab0c0c into main May 31, 2024
18 of 19 checks passed
@tolusha tolusha deleted the 22987 branch May 31, 2024 06:06
@devstudio-release
Copy link

Build 3.15 :: dashboard_3.x/499: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants