-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: podman login into external registries #1120
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha LGTM, I'd like to test but waiting for the build comment to be posted. Worst case, I'll try and build from your PR manually. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 89.60% 89.54% -0.07%
==========================================
Files 408 408
Lines 41604 41604
Branches 2786 2776 -10
==========================================
- Hits 37281 37254 -27
- Misses 4297 4323 +26
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1120 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1120", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works as expected after testing changes.
projects $ podman login --get-login docker.io
aobuchow
projects $ podman login --get-login quay.io
aobuchow
projects $
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, AObuchow, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.15 :: dashboard_3.x/499: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6902: Console, Changes, Git Data |
What does this PR do?
fix: podman login into external registries
What issues does this PR fix or reference?
eclipse-che/che#22987
Is it tested? How?
Yes
Release Notes
Docs PR