Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new route for Factory flow #517

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Add a new route for Factory flow #517

merged 1 commit into from
Apr 27, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 27, 2022

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Add a new route for Factory flow

What issues does this PR fix or reference?

fixes https://issues.redhat.com/browse/CRW-2907

Is it tested? How?

Release Notes

Docs PR

@olexii4
feat: add a new route for Factory flow
497a507 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from ibuziuk April 27, 2022 15:39
@olexii4 olexii4 requested a review from akurinnoy as a code owner April 27, 2022 15:39
@che-bot
Copy link
Contributor

che-bot commented Apr 27, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-517

ibuziuk
ibuziuk approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍
please backport to 7.46.x once merged

@openshift-ci openshift-ci bot added the lgtm label Apr 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 497a507 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olexii4 olexii4 merged commit 6b8429f into main Apr 27, 2022
@olexii4 olexii4 deleted the quick_fix_f branch April 27, 2022 19:33
@che-bot che-bot added this to the 7.48 milestone Apr 27, 2022
olexii4 added a commit that referenced this pull request Apr 27, 2022
@olexii4
feat: add a new route for Factory flow (#517)
27ca2f9 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 mentioned this pull request Apr 27, 2022
Merged
olexii4 added a commit that referenced this pull request Apr 28, 2022
@olexii4
feat: add a new route for Factory flow (#517) (#518)
2c17788 
* feat: add a new route for Factory flow (#517)

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* fix: add a manual contribution into dev.md file

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@akurinnoy akurinnoy Awaiting requested review from akurinnoy akurinnoy is a code owner

Assignees

@ibuziuk ibuziuk

Labels
lgtm
Projects
None yet
Milestone
7.48
Development

Successfully merging this pull request may close these issues.
3 participants
@olexii4 @che-bot @ibuziuk