Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a new route for Factory flow (#517) #518

Merged
merged 2 commits into from
Apr 28, 2022
Merged

feat: add a new route for Factory flow (#517) #518

merged 2 commits into from
Apr 28, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 27, 2022 •
edited by nickboldt
Loading

What does this PR do?

This PR is a cherry-pick of #517 to the 7.46.x branch

https://issues.redhat.com/browse/CRW-2907

What issues does this PR fix or reference?

Fixes eclipse-che/che#21032 in 7.46.x

https://issues.redhat.com/browse/CRW-2907

@olexii4
feat: add a new route for Factory flow (#517)
27ca2f9 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from ibuziuk April 27, 2022 20:46
@olexii4 olexii4 requested a review from akurinnoy as a code owner April 27, 2022 20:46
@che-bot
Copy link
Contributor

che-bot commented Apr 27, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-518

ibuziuk
ibuziuk reviewed Apr 28, 2022
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olexii4 looks like dash license check is failing

@olexii4
fix: add a manual contribution into dev.md file
febb355 
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Apr 28, 2022

Click here to review and test in web IDE: Contribute

@olexii4
Copy link
Contributor Author

olexii4 commented Apr 28, 2022 •
edited
Loading

@olexii4 looks like dash license check is failing

@ibuziuk I have fixed it.

@openshift-ci openshift-ci bot added the lgtm label Apr 28, 2022
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-518

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 2c17788 into 7.46.x Apr 28, 2022
@olexii4 olexii4 deleted the 7.46.x_pr517 branch April 28, 2022 10:45
@che-bot che-bot added this to the 7.46 milestone Apr 28, 2022
@nickboldt
Copy link
Contributor

Backport into 7.46.x: 2c17788
Build: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/CRW_CI/job/dashboard_3.0/18/
Image: https://quay.io/repository/devspaces/dashboard-rhel8?tab=tags&tag=3.0-20

no new bundle image yet, no new IIB.
Triggered: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/CRW_CI/job/operator-bundle_3.0/202/

expected: https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags&tag=3.0-35

Ready for testing:

$➔ ./getLatestIIBs.sh -t 3.0
Checking for latest IIBs for Dev Spaces 3.0 ...

  operator-bundle:3.0-35	registry-proxy.engineering.redhat.com/rh-osbs/iib:222888	v4.10
  operator-bundle:3.0-35	registry-proxy.engineering.redhat.com/rh-osbs/iib:222893	v4.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

Assignees

@ibuziuk ibuziuk

@akurinnoy akurinnoy

Labels
lgtm
Projects
None yet
Milestone
7.46
Development

Successfully merging this pull request may close these issues.
5 participants
@olexii4 @che-bot @nickboldt @ibuziuk @akurinnoy