fix: Do not set 'ephemeral' storage for the 'Safe' mode

[ibuziuk]

What does this PR do?

Do not set 'ephemeral' storage for the 'Safe' mode

What issues does this PR fix or reference?

• Changes in workspace get lost if restarting from local Devfile with typo che#22638
• https://issues.redhat.com/browse/CRW-4969

Is it tested? How?

• install Eclipse Che and patch the dashboard image

spec:
  components:
    dashboard:
      deployment:
        containers:
          - image: quay.io/eclipse/che-dashboard:pr-967

• Start an empty workspace
• Add a few files to the workspace and then add a devfile with an image that doesn't exist e.g.

schemaVersion: 2.2.0
metadata:
  name: devfile-with-typo
components:
  - name: tools
    container:
      image: quay.io/does/not/exist

• Select restart from local Devfile
• Wait for an error message
• Click the "Restart with default devfile" button.
• Wait for the target workspace to restart and open IDE
• See that the devfile exist and the changes are not lost

Release Notes

N/A

Docs PR

N/A

[che-bot]

Click here to review and test in web IDE:

[codecov]

Codecov Report

Merging #967 (78538ff) into main (a8820af) will increase coverage by 0.46%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
+ Coverage   84.71%   85.17%   +0.46%     
==========================================
  Files         363      380      +17     
  Lines       37514    39176    +1662     
  Branches     2440     2519      +79     
==========================================
+ Hits        31779    33369    +1590     
- Misses       5707     5780      +73     
+ Partials       28       27       -1     

Flag	Coverage Δ
unittests	85.17% <100.00%> (+0.46%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...paceProgress/CreatingSteps/Apply/Devfile/index.tsx	93.10% <100.00%> (+3.08%)	⬆️
...ontend/src/store/Workspaces/devWorkspaces/index.ts	77.50% <100.00%> (-0.16%)	⬇️

... and 29 files with indirect coverage changes

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-967

[ibuziuk]

@olexii4 @akurinnoy it looks like smth. is still wrong - after doing the workspace restart based on the local devfile changes disappear from the workspace? am I missing smth. or this PR is not enough to fix the issue

[dmytro-ndp]

I can confirm that workspace is still restarting with default devfile using ephemeral Storage Type: https://youtu.be/mFvwfgelhs8?si=43ZyfQOpn_JXtrlA

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-967

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-967

[olexii4]

it looks like smth. is still wrong - after doing the workspace restart based on the local devfile changes disappear from the workspace? am I missing smth. or this PR is not enough to fix the issue

@ibuziuk We still have an old issue: Restart based on the local Devfile doesn`t work properly

[akurinnoy]

@ibuziuk @dmytro-ndp please test the PR.

[dmytro-ndp]

Looks good to merge. Well done!
Verification screencast: https://youtu.be/XrIgFNEz0qY

[ibuziuk]

@ibuziuk We still have an old issue: eclipse-che/che#22453

yeah, but this is unrelated to the ephemeral mode I believe. @olexii4 Could you please review & approve if all is good with this PR in regard to eclipse-che/che#22638 ?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.10 :: dashboard_3.10/12: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: dashboard_3.x/384: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.10/85: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: sync-to-downstream_3.x/5155: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5038: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.10/84: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: push-latest-container-to-quay_3.x/3581: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: push-latest-container-to-quay_3.10/49: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5038:

dashboard : 3.x :: Build 56712827 : quay.io/devspaces/dashboard-rhel8:3.11-12
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3581 triggered

[devstudio-release]

Build 3.11 :: dashboard_3.x/384:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5155 triggered

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.10/84:

dashboard : 3.10 :: Build 56712838 : quay.io/devspaces/dashboard-rhel8:3.10-46
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.10/49 triggered

[devstudio-release]

Build 3.11 :: update-digests_3.x/4777: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: dashboard_3.10/12:

Upstream sync done; /DS_CI/sync-to-downstream_3.10/85 triggered

[devstudio-release]

Build 3.11 :: operator-bundle_3.x/2247: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: sync-to-downstream_3.x/5156: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5039: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: update-digests_3.10/86: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: update-digests_3.10/86:

No new images detected: nothing to do!

[devstudio-release]

Build 3.11 :: push-latest-container-to-quay_3.x/3582: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5039:

devspaces-operator-bundle : 3.x :: Build 56714279 : quay.io/devspaces/devspaces-operator-bundle:3.11-22
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3582 triggered;

Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.11-3
- quay.io/devspaces/configbump-rhel8:3.11-2
- quay.io/devspaces/dashboard-rhel8:3.11-12
- quay.io/devspaces/devfileregistry-rhel8:3.11-13
- quay.io/devspaces/devspaces-rhel8-operator:3.11-4
- quay.io/devspaces/idea-rhel8:3.11-2
- quay.io/devspaces/pluginregistry-rhel8:3.11-2
- quay.io/devspaces/server-rhel8:3.11-2
- quay.io/devspaces/traefik-rhel8:3.11-2
- quay.io/devspaces/udi-rhel8:3.11-3
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202310241244.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202310201022.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

[devstudio-release]

Build 3.11 :: copyIIBsToQuay/2070: Console, Changes, Git Data

[devstudio-release]

Build 3.11 :: sync-to-downstream_3.x/5156:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5039 triggered; /job/DS_CI/job/dsc_3.x triggered;

[devstudio-release]

Build 3.11 :: operator-bundle_3.x/2247:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5156 triggered

[devstudio-release]

Build 3.11 :: update-digests_3.x/4777:

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2247 triggered

[devstudio-release]

Build 3.11 :: dsc_3.x/1513: Console, Changes, Git Data