14871 add testrunner #602

tsmaeder · 2020-09-01T12:44:03Z

What does this PR do?

Adds the Java testrunner extension to all Java-related plugins. The version is 0.24.0, since 0.24.1 requires Java 11 to run.

This issue fixes Installing Java Test Runner Support for Java eclipse-che/che#14871

ericwill · 2020-09-01T13:06:05Z

v3/plugins/redhat/java8/0.63.0a/meta.yaml

@@ -0,0 +1,24 @@
+apiVersion: v2
+publisher: redhat
+name: java


Should be java8

che-bot · 2020-09-01T13:12:10Z

@tsmaeder Happy Path PR check [build 282] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/282/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/282/

Depending on failure reason, the artifacts or deployment may not be present.

che-bot · 2020-09-01T13:13:38Z

@tsmaeder Happy Path PR check [build 283] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/283/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/283/

Depending on failure reason, the artifacts or deployment may not be present.

svor

LGTM

ericwill · 2020-09-01T13:31:23Z

We should probably deprecate 0.63.0 and set it to migrate to 0.63.0a

che-bot · 2020-09-01T14:02:44Z

@tsmaeder Happy Path PR check [build 284] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/284/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/284/

Depending on failure reason, the artifacts or deployment may not be present.

rhopp · 2020-09-04T12:04:20Z

[ci-test-happy-path]

che-bot · 2020-09-04T12:42:56Z

Happy path tests passed.

rhopp · 2020-09-04T12:49:30Z

There was probably some glitch... I couldn't reproduce this running the tests locally and next run of the PR check succeeded.

tsmaeder · 2020-09-07T11:34:06Z

We should probably deprecate 0.63.0 and set it to migrate to 0.63.0a

Hhmh...why? If anything, shouldn't we deprecate 0.57? 0.63 works just fine, and if the user wants the new features, he can update by hand. There is nothing special about 0.63a except that the version of vscode-java did not change.

che-bot · 2020-09-08T08:16:03Z

@tsmaeder Happy Path PR check [build 301] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/301/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/301/

Depending on failure reason, the artifacts or deployment may not be present.

tsmaeder · 2020-09-08T09:14:02Z

[ci-test]

che-bot · 2020-09-08T09:39:26Z

@tsmaeder Happy Path PR check [build 303] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/303/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/303/

Depending on failure reason, the artifacts or deployment may not be present.

ericwill · 2020-09-08T12:22:53Z

We should probably deprecate 0.63.0 and set it to migrate to 0.63.0a

Hhmh...why? If anything, shouldn't we deprecate 0.57? 0.63 works just fine, and if the user wants the new features, he can update by hand. There is nothing special about 0.63a except that the version of vscode-java did not change.

I suppose it could be optional, but it would be nice to have all users be able to take advantage of the new test runner support out of the box, and it's not immediately obvious that such new features are available just by visual inspection. Since there is no vscode-java version change from 0.63.0 to 0.63.0a it's a harmless migration.

ericwill · 2020-09-08T12:24:17Z

v3/plugins/redhat/java11/0.63.0a/meta.yaml

+    - https://download.jboss.org/jbosstools/vscode/3rdparty/vscode-java-debug/vscode-java-debug-0.26.0.vsix
+    - https://download.jboss.org/jbosstools/static/jdt.ls/stable/java-0.63.0-2222.vsix
+    - https://open-vsx.org/api/vscjava/vscode-java-test/0.24.0/file/vscjava.vscode-java-test-0.24.0.vsix
+


Extra newlines/missing newling at EOF? Looks like something weird happened here.

che-bot · 2020-09-09T08:25:56Z

@tsmaeder Happy Path PR check [build 310] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/310/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/310/

Depending on failure reason, the artifacts or deployment may not be present.

tsmaeder · 2020-09-09T11:14:25Z

[ci-test-happy-path]

che-bot · 2020-09-09T11:31:45Z

@tsmaeder Happy Path PR check [build 311] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/311/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/311/

Depending on failure reason, the artifacts or deployment may not be present.

tsmaeder · 2020-09-09T14:07:02Z

[ci-test-happy-path]

che-bot · 2020-09-09T14:10:25Z

@tsmaeder Happy Path PR check [build 312] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/312/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/312/

Depending on failure reason, the artifacts or deployment may not be present.

Signed-off-by: Thomas Mäder <tmader@redhat.com>

benoitf · 2020-09-11T11:29:47Z

I've rebased this PR

che-bot · 2020-09-11T12:00:16Z

@tsmaeder Happy Path PR check [build 332] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/332/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/332/

Depending on failure reason, the artifacts or deployment may not be present.

ericwill · 2020-09-11T14:58:49Z

Superseded by #619

tsmaeder requested review from benoitf, ericwill, svor, vinokurig and vitaliy-guliy as code owners September 1, 2020 12:44

tsmaeder force-pushed the 14871_add_testrunner branch from f603894 to a832339 Compare September 1, 2020 12:45

ericwill reviewed Sep 1, 2020

View reviewed changes

svor approved these changes Sep 1, 2020

View reviewed changes

ericwill reviewed Sep 8, 2020

View reviewed changes

ericwill mentioned this pull request Sep 9, 2020

Unable to run Junit tests in Eclipse Che - Right click and run does not work eclipse-che/che#17818

Closed

22 tasks

tsmaeder added 3 commits September 11, 2020 13:27

Add testrunner to Java related plugins

32c9574

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fix plugin name

546a8ee

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Deprecate previous version

2eda12e

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Remove extra newline

c856d3a

Signed-off-by: Thomas Mäder <tmader@redhat.com>

benoitf force-pushed the 14871_add_testrunner branch from 594ec63 to c856d3a Compare September 11, 2020 11:28

ericwill mentioned this pull request Sep 11, 2020

Add Java test runner support to Che #619

Merged

ericwill closed this Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

14871 add testrunner #602

14871 add testrunner #602

tsmaeder commented Sep 1, 2020

ericwill Sep 1, 2020

che-bot commented Sep 1, 2020

che-bot commented Sep 1, 2020

svor left a comment

ericwill commented Sep 1, 2020

che-bot commented Sep 1, 2020

rhopp commented Sep 4, 2020

che-bot commented Sep 4, 2020

rhopp commented Sep 4, 2020

tsmaeder commented Sep 7, 2020

che-bot commented Sep 8, 2020

tsmaeder commented Sep 8, 2020

che-bot commented Sep 8, 2020

ericwill commented Sep 8, 2020

ericwill Sep 8, 2020

che-bot commented Sep 9, 2020

tsmaeder commented Sep 9, 2020

che-bot commented Sep 9, 2020

tsmaeder commented Sep 9, 2020

che-bot commented Sep 9, 2020

benoitf commented Sep 11, 2020

che-bot commented Sep 11, 2020

ericwill commented Sep 11, 2020

14871 add testrunner #602

14871 add testrunner #602

Conversation

tsmaeder commented Sep 1, 2020

What does this PR do?

ericwill Sep 1, 2020

Choose a reason for hiding this comment

che-bot commented Sep 1, 2020

@tsmaeder Happy Path PR check [build 282] failed.

Depending on failure reason, the artifacts or deployment may not be present.

che-bot commented Sep 1, 2020

@tsmaeder Happy Path PR check [build 283] failed.

Depending on failure reason, the artifacts or deployment may not be present.

svor left a comment

Choose a reason for hiding this comment

ericwill commented Sep 1, 2020

che-bot commented Sep 1, 2020

@tsmaeder Happy Path PR check [build 284] failed.

Depending on failure reason, the artifacts or deployment may not be present.

rhopp commented Sep 4, 2020

che-bot commented Sep 4, 2020

rhopp commented Sep 4, 2020

tsmaeder commented Sep 7, 2020

che-bot commented Sep 8, 2020

@tsmaeder Happy Path PR check [build 301] failed.

Depending on failure reason, the artifacts or deployment may not be present.

tsmaeder commented Sep 8, 2020

che-bot commented Sep 8, 2020

@tsmaeder Happy Path PR check [build 303] failed.

Depending on failure reason, the artifacts or deployment may not be present.

ericwill commented Sep 8, 2020

ericwill Sep 8, 2020

Choose a reason for hiding this comment

che-bot commented Sep 9, 2020

@tsmaeder Happy Path PR check [build 310] failed.

Depending on failure reason, the artifacts or deployment may not be present.

tsmaeder commented Sep 9, 2020

che-bot commented Sep 9, 2020

@tsmaeder Happy Path PR check [build 311] failed.

Depending on failure reason, the artifacts or deployment may not be present.

tsmaeder commented Sep 9, 2020

che-bot commented Sep 9, 2020

@tsmaeder Happy Path PR check [build 312] failed.

Depending on failure reason, the artifacts or deployment may not be present.

benoitf commented Sep 11, 2020

che-bot commented Sep 11, 2020

@tsmaeder Happy Path PR check [build 332] failed.

Depending on failure reason, the artifacts or deployment may not be present.

ericwill commented Sep 11, 2020