Add Java test runner support to Che #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder <tmader@redhat.com>
ericwill
requested review from
benoitf,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
Closed
|
you could have just pushed to previous PR :-) I think there is still a problem when the java test runner is added I saw that in the video of happy path test, there was 'Activating test runner...' at the bottom but I didn't investigate much |
|
Happy path tests passed. |
benoitf
approved these changes
Sep 11, 2020
|
let's merge it :D |
It's normal, Thomas made a demo video of it working fine. |
22 tasks
monaka
pushed a commit
to PizzaFactory/che-plugin-registry
that referenced
this pull request
Sep 18, 2020
* Add testrunner to Java related plugins Signed-off-by: Thomas Mäder <tmader@redhat.com> * Fix plugin name Signed-off-by: Thomas Mäder <tmader@redhat.com> * Deprecate previous version Signed-off-by: Thomas Mäder <tmader@redhat.com> * Remove extra newline Signed-off-by: Thomas Mäder <tmader@redhat.com> Co-authored-by: Thomas Mäder <tmader@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-upload of #602 in order to get CI to pass.