Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the build.sh script to work with podman #559

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Modify the build.sh script to work with podman #559

merged 14 commits into from
Dec 11, 2023

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Sep 11, 2023

What does this PR do?

In order to be able to build images directly in a wotkspace container, add BUILDER variable to be able to execute the build.sh script not only with docker but with podman and buildah.

depends on #573

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#22243

How to test this PR?

  1. Start a workspace from the che-server repository
  2. Git checkout to the che-22243 brach
  3. In the workspace terminal run cd dockerfiles and .build.sh commands

See: a new image has been built.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig
Copy link
Contributor Author

/retest

1 similar comment
@ibuziuk
Copy link
Member

ibuziuk commented Sep 12, 2023

/retest

@tolusha
Copy link
Contributor

tolusha commented Sep 13, 2023

Please, rebase on main to have tests passed.

@vinokurig vinokurig force-pushed the che-22243 branch 2 times, most recently from cf8201c to 1e91107 Compare September 18, 2023 11:21
@ibuziuk ibuziuk requested review from SDawley and nickboldt and removed request for nickboldt September 26, 2023 09:43
@ibuziuk
Copy link
Member

ibuziuk commented Sep 26, 2023

@nickboldt @SDawley please, review
need your approval before merging + clarity with #468

@ibuziuk
Copy link
Member

ibuziuk commented Sep 26, 2023

/retest

@vinokurig vinokurig mentioned this pull request Sep 27, 2023
9 tasks
dockerfiles/build.include Outdated Show resolved Hide resolved
devfile.yaml Outdated Show resolved Hide resolved
dockerfiles/build.include Outdated Show resolved Hide resolved
dockerfiles/build.include Outdated Show resolved Hide resolved
dockerfiles/build.include Outdated Show resolved Hide resolved
@openshift-merge-robot
Copy link

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-github-with-pat-setup-flow 3637fac link true /test v12-github-with-pat-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vinokurig
Copy link
Contributor Author

/retest

vinokurig and others added 12 commits October 19, 2023 15:29
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
@vinokurig
Copy link
Contributor Author

@ibuziuk @nickboldt @SDawley Please take a look

@vinokurig
Copy link
Contributor Author

/retest

@vinokurig
Copy link
Contributor Author

/retest

@vinokurig
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-git-no-pat-oauth-flow 83859fd link true /test v12-git-no-pat-oauth-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vinokurig
Copy link
Contributor Author

/retest

@vinokurig
Copy link
Contributor Author

@nickboldt @ibuziuk Could you please review?

Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 3ecfbcd into main Dec 11, 2023
22 checks passed
@vinokurig vinokurig deleted the che-22243 branch December 11, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants