Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dockerfiles to build/dockerfiles #573

Merged
merged 11 commits into from
Oct 19, 2023
Merged

Move dockerfiles to build/dockerfiles #573

merged 11 commits into from
Oct 19, 2023

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Moves dockerfiles from dockerfiles/che to build/dockerfiles
Removes the endpoint-watcher, postgres and keycloak images.
Adds brew.Dockerfile from downstream.

Coauthored with @SDawley

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4043

How to test this PR?

Run ./build/dockerfiles/build.sh from the project's root directory.
See: docker image quay.io/eclipse/che-server:next has been built.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig vinokurig changed the title 4043 Move dockerfiles to build/dockerfiles Sep 26, 2023
@ibuziuk ibuziuk requested a review from SDawley September 26, 2023 11:54
build/build.include Outdated Show resolved Hide resolved
@nickboldt
Copy link
Contributor

I'm assuming we plan to merge #559 before this one otherwise you'll end up recreting deleted files (like for postgres).

@vinokurig
Copy link
Contributor Author

@nickboldt

I'm assuming we plan to merge #559 before this one otherwise you'll end up recreting deleted files (like for postgres).

I prefer to merge this PR first and then fix the #559 PR

@tolusha
Copy link
Contributor

tolusha commented Sep 26, 2023

/restart

@tolusha
Copy link
Contributor

tolusha commented Sep 26, 2023

/test v12-gitlab-no-pat-oauth-flow

build/build.sh Outdated Show resolved Hide resolved
make-release.sh Show resolved Hide resolved
make-release.sh Outdated Show resolved Hide resolved
@openshift-merge-robot
Copy link

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-github-no-pat-oauth-flow-raw-devfile-url 116297a link true /test v12-github-no-pat-oauth-flow-raw-devfile-url

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

make-release.sh Outdated Show resolved Hide resolved
make-release.sh Outdated Show resolved Hide resolved
make-release.sh Outdated Show resolved Hide resolved
make-release.sh Outdated Show resolved Hide resolved
make-release.sh Outdated Show resolved Hide resolved
make-release.sh Outdated Show resolved Hide resolved
vinokurig and others added 8 commits October 11, 2023 11:36
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
@vinokurig
Copy link
Contributor Author

/retest

2 similar comments
@vinokurig
Copy link
Contributor Author

/retest

@nickboldt
Copy link
Contributor

/retest

@nickboldt nickboldt self-requested a review October 18, 2023 20:25
@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devstudio-release
Copy link

Build 3.10 :: server_3.x/262: Console, Changes, Git Data

nickboldt added a commit to redhat-developer/devspaces-images that referenced this pull request Oct 26, 2023
… )

Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt added a commit to redhat-developer/devspaces-images that referenced this pull request Nov 14, 2023
Change-Id: I4daaec4ad95e40a87b553150b914d826165dcf0f
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants