-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dockerfiles to build/dockerfiles #573
Conversation
I'm assuming we plan to merge #559 before this one otherwise you'll end up recreting deleted files (like for postgres). |
/restart |
/test v12-gitlab-no-pat-oauth-flow |
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: sdawley <sdawley@redhat.com>
…es. Add brew.Dockerfile.
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
Co-authored-by: Nick Boldt <nboldt@redhat.com>
/retest |
2 similar comments
/retest |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.10 :: server_3.x/262: Console, Changes, Git Data |
… ) Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I4daaec4ad95e40a87b553150b914d826165dcf0f Signed-off-by: Nick Boldt <nboldt@redhat.com>
What does this PR do?
Moves dockerfiles from dockerfiles/che to build/dockerfiles
Removes the endpoint-watcher, postgres and keycloak images.
Adds brew.Dockerfile from downstream.
Coauthored with @SDawley
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4043
How to test this PR?
Run
./build/dockerfiles/build.sh
from the project's root directory.See: docker image
quay.io/eclipse/che-server:next
has been built.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.