Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: comment out node10 (updated to node18) and maven 3.6 (updated to 3.8) installs, as we likely don't need them (either not required or handled by GH action) #22616 #593

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Oct 18, 2023

What does this PR do?

comment out node10 (updated to node18) and maven 3.6 (updated to 3.8) installs, as we likely don't need them (either not required or handled by GH action) #22616

use maven 3.8 for typescript-dto build too (not 3.6.1)

Change-Id: I5d0920b58e413247fd5466a269fb26b1af60578c
Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22616

Recommend merging #573 before this PR, after Che 7.76.0 is released.

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… installs, as we likely don

't need them (either not required or handled by GH action) #22616

Change-Id: I5d0920b58e413247fd5466a269fb26b1af60578c
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt changed the title comment out node10 (updated to node18) and... chore: comment out node10 (updated to node18) and maven 3.6 (updated to 3.8) installs, as we likely don't need them (either not required or handled by GH action) #22616 Oct 18, 2023
Change-Id: Ie70fa428ba1a68bbe663577947f05b6a2c4fe3a6
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I83fc89be6ad2411b64a4bf4e2308c048a9ab2ff4
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

@nickboldt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-azure-no-pat-oauth-flow-raw-devfile-url 270be77 link true /test v12-azure-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-bitbucket-no-pat-oauth-flow-ssh-url 270be77 link true /test v12-bitbucket-no-pat-oauth-flow-ssh-url
ci/prow/v12-azure-no-pat-oauth-flow 270be77 link true /test v12-azure-no-pat-oauth-flow
ci/prow/v12-gitea-no-pat-oauth-flow 270be77 link true /test v12-gitea-no-pat-oauth-flow
ci/prow/v12-github-with-pat-setup-flow 270be77 link true /test v12-github-with-pat-setup-flow
ci/prow/v12-gitlab-no-pat-oauth-flow 270be77 link true /test v12-gitlab-no-pat-oauth-flow
ci/prow/v12-bitbucket-no-pat-oauth-flow 270be77 link true /test v12-bitbucket-no-pat-oauth-flow
ci/prow/v12-github-no-pat-oauth-flow-ssh-url 270be77 link true /test v12-github-no-pat-oauth-flow-ssh-url
ci/prow/v12-github-no-pat-oauth-flow 270be77 link true /test v12-github-no-pat-oauth-flow
ci/prow/v12-github-no-pat-oauth-flow-raw-devfile-url 270be77 link true /test v12-github-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-bitbucket-no-pat-oauth-flow-raw-devfile-url 270be77 link true /test v12-bitbucket-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-azure-no-pat-oauth-flow-ssh-url 270be77 link true /test v12-azure-no-pat-oauth-flow-ssh-url
ci/prow/v12-gitlab-with-pat-setup-flow 270be77 link true /test v12-gitlab-with-pat-setup-flow
ci/prow/v12-gitlab-no-pat-oauth-flow-raw-devfile-url 270be77 link true /test v12-gitlab-no-pat-oauth-flow-raw-devfile-url
ci/prow/v12-gitea-with-pat-setup-flow 270be77 link true /test v12-gitea-with-pat-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nickboldt
Copy link
Contributor Author

/retest

@nickboldt nickboldt requested a review from SDawley October 19, 2023 16:52
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SDawley
Copy link
Contributor

SDawley commented Oct 19, 2023

Build/required checks passed, so merging,

@SDawley SDawley merged commit c4156b6 into main Oct 19, 2023
4 checks passed
@SDawley SDawley deleted the 22616 branch October 19, 2023 17:16
@devstudio-release
Copy link

Build 3.10 :: server_3.x/263: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: server_3.x/264: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: server_3.x/265: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: server_3.x/266: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: server_3.x/267: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: get-sources-rhpkg-container-build_3.x/4947: FAILURE

server : 3.x :: Failed in 56559513 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.11 :: server_3.x/268: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.x/268: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5102 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4709: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.11 :: server_3.x/269: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.x/269: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5120 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4734: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.10 :: server_3.10/5: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants