-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: comment out node10 (updated to node18) and maven 3.6 (updated to 3.8) installs, as we likely don't need them (either not required or handled by GH action) #22616 #593
Conversation
… installs, as we likely don 't need them (either not required or handled by GH action) #22616 Change-Id: I5d0920b58e413247fd5466a269fb26b1af60578c Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: Ie70fa428ba1a68bbe663577947f05b6a2c4fe3a6 Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I83fc89be6ad2411b64a4bf4e2308c048a9ab2ff4 Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt, SDawley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build/required checks passed, so merging, |
Build 3.10 :: server_3.x/263: Console, Changes, Git Data |
Build 3.10 :: server_3.x/264: Console, Changes, Git Data |
Build 3.11 :: server_3.x/265: Console, Changes, Git Data |
Build 3.11 :: server_3.x/266: Console, Changes, Git Data |
Build 3.11 :: server_3.x/267: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5099: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/4947: server : 3.x :: Failed in 56559513 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.11 :: server_3.x/268: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5102: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3529: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/4951: server : 3.x :: Build 56560021 : quay.io/devspaces/server-rhel8:3.11-1 |
Build 3.11 :: server_3.x/268: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5102 triggered |
Build 3.11 :: update-digests_3.x/4709: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/4709: No new images detected: nothing to do! |
Build 3.11 :: server_3.x/269: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5120: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3546: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/4969: server : 3.x :: Build 56596304 : quay.io/devspaces/server-rhel8:3.11-2 |
Build 3.11 :: server_3.x/269: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5120 triggered |
Build 3.11 :: update-digests_3.x/4734: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/4734: No new images detected: nothing to do! |
Build 3.10 :: server_3.10/5: Console, Changes, Git Data |
What does this PR do?
comment out node10 (updated to node18) and maven 3.6 (updated to 3.8) installs, as we likely don't need them (either not required or handled by GH action) #22616
use maven 3.8 for typescript-dto build too (not 3.6.1)
Change-Id: I5d0920b58e413247fd5466a269fb26b1af60578c
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#22616
Recommend merging #573 before this PR, after Che 7.76.0 is released.
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.